Bug 498324
| Summary: | Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Krause <chkr> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.03-3.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-06 23:29:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christian Krause
2009-04-29 20:57:02 UTC
Alright, here is the review. Nothing serious:
! Please make the description span 80 columns evenly (as much as possible)
! The file Changes can be packaged as %doc
! There is no information about the license except at the end of the lib/JSON/RPC/Common.pm file. Could you advise upstream for putting a COPYING file into the tarball and adding headers that contain license information to the source files?
! It looks like these BR's can be removed:
BuildRequires: perl(Moose)
BuildRequires: perl(namespace::clean)
The package builds fine without them. The other packages pull them in so they don't cause any harm. I'll leave this up to you.
* Packages must not own files or directories already owned by other packages. I don't think this package should own %{perl_vendorlib}/JSON/ . It should own
%{perl_vendorlib}/JSON/RPC instead. Ownership of %{perl_vendorlib}/JSON/ will be satisfied by rpm's automatic dependency generation.
(In reply to comment #1) > Alright, here is the review. Nothing serious: Thank you very much for the review! > ! Please make the description span 80 columns evenly (as much as possible) Done. > ! The file Changes can be packaged as %doc Done. > ! There is no information about the license except at the end of the > lib/JSON/RPC/Common.pm file. Could you advise upstream for putting a COPYING > file into the tarball and adding headers that contain license information to > the source files? Yes, I've mailed upstream. The author replied that he'll have a look at this. > ! It looks like these BR's can be removed: > BuildRequires: perl(Moose) > BuildRequires: perl(namespace::clean) > The package builds fine without them. The other packages pull them in so they > don't cause any harm. I'll leave this up to you. Done, I've removed them. > * Packages must not own files or directories already owned by other packages. I > don't think this package should own %{perl_vendorlib}/JSON/ . It should own > %{perl_vendorlib}/JSON/RPC instead. Ownership of %{perl_vendorlib}/JSON/ will > be satisfied by rpm's automatic dependency generation. Done. new package: Spec URL: http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common.spec SRPM URL: http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common-0.03-2.fc10.src.rpm Thanks. But now we have the rpmlints: perl-JSON-RPC-Common.src: E: description-line-too-long objects to convert the model objects into JSON text and HTTP requests/responses. perl-JSON-RPC-Common.src:54: W: macro-in-%changelog doc perl-JSON-RPC-Common.src:56: W: macro-in-%changelog perl_vendorlib Please fix these. Also, running rpmlint on the SPEC and SRPM files after you're done editing is a good idea. (In reply to comment #3) > Please fix these. Also, running rpmlint on the SPEC and SRPM files after you're > done editing is a good idea. Sure, your're right. Here are the new packages: Spec URL: http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common.spec SRPM URL: http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common-0.03-3.fc10.src.rpm Great. Thanks! ------------------------------------------------------- This package (perl-JSON-RPC-Common) is APPROVED by oget ------------------------------------------------------- New Package CVS Request ======================= Package Name: perl-JSON-RPC-Common Short Description: Perl module for handling JSON-RPC objects Owners: chkr Branches: F-10 F-11 InitialCC: CVS Done perl-JSON-RPC-Common-0.03-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-JSON-RPC-Common-0.03-3.fc10 perl-JSON-RPC-Common-0.03-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-JSON-RPC-Common-0.03-3.fc11 Package Change Request ====================== Package Name: perl-JSON-RPC-Common New Branches: F-9 Owners: chkr cvs done. perl-JSON-RPC-Common-0.03-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-JSON-RPC-Common-0.03-3.fc9 perl-JSON-RPC-Common-0.03-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. perl-JSON-RPC-Common-0.03-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. perl-JSON-RPC-Common-0.03-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |