Bug 498489
| Summary: | blktrace stops working after a trace-file-directory replacement | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Milos Malik <mmalik> |
| Component: | kernel | Assignee: | Eric Sandeen <esandeen> |
| Status: | CLOSED ERRATA | QA Contact: | Red Hat Kernel QE team <kernel-qe> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.3 | CC: | dzickus, esandeen, syeghiay, yugzhang |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-30 07:31:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 533192 | ||
|
Description
Milos Malik
2009-04-30 17:42:18 UTC
Hm, seems to work for me on /dev/sda. Did you always test with /dev/md0? [root@bear-05 tmp]# blktrace -d /dev/sda -w 5 Device: /dev/sda CPU 0: 0 events, 4 KiB data CPU 1: 0 events, 1 KiB data CPU 2: 0 events, 0 KiB data CPU 3: 0 events, 0 KiB data Total: 0 events (dropped 0), 4 KiB data [root@bear-05 tmp]# ls -l *.blktrace.* -rw-r--r-- 1 root root 3248 Apr 30 13:19 sda.blktrace.0 -rw-r--r-- 1 root root 464 Apr 30 13:19 sda.blktrace.1 -rw-r--r-- 1 root root 0 Apr 30 13:19 sda.blktrace.2 -rw-r--r-- 1 root root 0 Apr 30 13:19 sda.blktrace.3 [root@bear-05 tmp]# rm sda.blktrace.1 rm: remove regular file `sda.blktrace.1'? y [root@bear-05 tmp]# mkdir sda.blktrace.1 [root@bear-05 tmp]# blktrace -d /dev/sda -w 5 ./sda.blktrace.1: Is a directory Failed to start worker threads [root@bear-05 tmp]# rmdir sda.blktrace.1 [root@bear-05 tmp]# blktrace -d /dev/sda -w 5 Device: /dev/sda CPU 0: 0 events, 0 KiB data CPU 1: 0 events, 9 KiB data CPU 2: 0 events, 162 KiB data CPU 3: 0 events, 0 KiB data Total: 0 events (dropped 0), 171 KiB data [root@bear-05 tmp]# rm -f *blktrace* [root@bear-05 tmp]# blktrace -d /dev/sda -w 5 Device: /dev/sda CPU 0: 0 events, 0 KiB data CPU 1: 0 events, 1 KiB data CPU 2: 0 events, 4 KiB data CPU 3: 0 events, 0 KiB data Total: 0 events (dropped 0), 5 KiB data Maybe I should ask which kernel you're testing? I still can't reproduce this, although I think I see a couple upstream patches which help with the proper teardown in some circumstances.... Thanks, -Eric http://git.engineering.redhat.com/?p=linux-2.6.git;a=commitdiff_plain;h=35fc51e7a5056889421270c1fb63d8ec45fbccf4 seem to fix this; it's a kernel change. From: Aneesh Kumar K.V <aneesh.kumar.ibm.com> Date: Wed, 21 Nov 2007 11:25:41 +0000 (+0100) Subject: blktrace: Make sure BLKTRACETEARDOWN does the full cleanup. X-Git-Tag: v2.6.24-rc4~87^2~5 X-Git-Url: http://git.engineering.redhat.com/?p=linux-2.6.git;a=commitdiff_plain;h=35fc51e7a5056889421270c1fb63d8ec45fbccf4 blktrace: Make sure BLKTRACETEARDOWN does the full cleanup. if blktrace program segfault it will not be able to call BLKTRACETEARDOWN. Now if we run the blktrace again that would result in a failure to create the block/<device> debugfs directory.This will result in blk_remove_root() to be called which will set blk_tree_root to NULL. But the debugfs block dir still exist because it contain subdirectory. Now if we try to fix it using BLKTRACETEARDOWN it won't work because blk_tree_root is NULL. Fix the same. -------- I guess we'll need an exception to get this in ... -Eric Requestion exception for this one, without it blktrace gets into a state where tracing no longer works. Change is uptream, and is confined to block/blktrace.c which can't regress, since we've never supported it before ... This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. in kernel-2.6.18-179.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please update the appropriate value in the Verified field (cf_verified) to indicate this fix has been successfully verified. Include a comment with verification details. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html |