Bug 498503

Summary: [PATCH] Fix use of freed file name when unable to import VPN config
Product: [Fedora] Fedora Reporter: Lubomir Rintel <lkundrak>
Component: NetworkManagerAssignee: Dan Williams <dcbw>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: aleksey, arxs, dcbw, huzaifas, lkundrak
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 497992 Environment:
Last Closed: 2009-05-04 17:34:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix for use-after-free issue none

Description Lubomir Rintel 2009-04-30 19:08:26 UTC 
Created attachment 341981 [details]
Fix for use-after-free issue

This bug was reported against EPEL's vpnc plugin, but it a NetworkManager issue present in Fedora as well. Attached patch was created against RHEL 5.3 NM and was tested to fix the issue.

You can reproduce it reliably:
1.) MALLOC_PERTURB_=123 nm-connection-settings
2.) Import VPN settings, select file that is not correct VPN settings
3.) See the error message

+++ This bug was initially created as a clone of Bug #497992 +++

Created an attachment (id=341551)
Importing pcf file error
...
Additional info:
The file name in the attachment is not correct. The file name seems to change randomly.
Comment 1 Niels Haase 2009-05-02 08:38:13 UTC 
Thanks for the patch. But if you make changes to NetworkManager, create the
patch using a unified diff format (ie, diff -u) and mail the patch to the
NetworkManager list (networkmanager-list). Thanks

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
Comment 2 Dan Williams 2009-05-04 17:34:09 UTC 
a5f246b34a532f536d2d7d711a5bd9f132cffa2e (master)
b9b45320c0dd2e4bd24a63e24793a10e7d4fe52f (0.7)

Thanks!