Bug 498604
Summary: | Review Request: apron - Abstract numerical domain library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alan Dunn <amdunn> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-11-20 15:48:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Alan Dunn
2009-05-01 13:00:39 UTC
Just a few comments: No parallel make? Sure would go faster on my lots-of-cores builder. If it doesn't work you should at least add a comment indicating that. I'm having trouble understanding the reasoning here: > The first category of warnings are all about inclusion of libraries in the > main package. Ostensibly, the whole purpose of the apron package is these > libraries, so I was not sure of whether these belong in -devel. So here's my question: What good are the static libraries without the headers in the -devel package? Static libraries have no runtime use at all; they'll be embedded into executables at build time The guidelines on static libraries should be pretty clear: http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries They should be in a separate -static package unless you really have no shared libraries at all, in which case they can be in -devel but you must still provide the -static symbol so that other packages can BuildRequires: apron-static. The prelink file confuses me. Why is it in the main package? Actually, why is anything at all in the main package? Thanks for the comments. (In reply to comment #1) > Just a few comments: > > No parallel make? Sure would go faster on my lots-of-cores builder. If it > doesn't work you should at least add a comment indicating that. I didn't look at this, so I'll see what I can do about allowing this. > I'm having trouble understanding the reasoning here: > > The first category of warnings are all about inclusion of libraries in the > > main package. Ostensibly, the whole purpose of the apron package is these > > libraries, so I was not sure of whether these belong in -devel. > > So here's my question: What good are the static libraries without the headers > in the -devel package? Static libraries have no runtime use at all; they'll be > embedded into executables at build time > > The guidelines on static libraries should be pretty clear: > http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries > They should be in a separate -static package unless you really have no shared > libraries at all, in which case they can be in -devel but you must still > provide the -static symbol so that other packages can BuildRequires: > apron-static. > The prelink file confuses me. Why is it in the main package? You're right - this should go in ocaml-apron. > Actually, why is anything at all in the main package? Well, I would think the few minor documentation files (since they are probably not enough to comprise a whole doc subpackage) could go there. I can certainly move all the static libraries to the devel subpackage, it just seemed odd to put these in apron-devel as the purpose of the whole package is already for development. I saw the guidelines, I just thought another opinion might be in order nonetheless. I'll just move the files to devel as long as it's okay to have essentially an empty main package. Had you had the headers in the main package as well, I suppose I'd agree with you, but you put them in -devel which makes the main pacakge essentially useless. You didn't answer my question about what good the static libs are without the headers. I don't think there's any actual requirement for you to build a main package at all. Just build -devel, and if upstream in the future starts producing shared libraries then you can start producing a main package containing the libraries, a -devel package with the usual bits and a -static package with the .a files. Was there any progress? It's been four months since the last comment with no response; I'll go ahead and close this out soon if nothing further happens. No response; closing. |