Bug 498744
| Summary: | Review Request: grfcodec - A suite of programs to modify Transport Tycoon Deluxe's GRF files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | atorkhov, fedora-package-review, felix, hdegoede, musuruan, notting |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.9.11-0.2.r2111.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-07 03:44:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 491519 | ||
|
Description
Iain Arnell
2009-05-02 17:43:50 UTC
Hi,
FULL review done, here are the results:
MUST FIX:
-add comments how *exactly* to generate the tarbal from svn
-License should be GPLv2+
-Patch Makefile to not pass -O3 to gcc, that is not part of the default
Fedora CFLAGS
Should FIX:
-Preserve timestamps of docs while converting them, replace:
iconv -f iso8859-1 -t utf-8 $f >$f.conv && mv $f.conv $f
with:
iconv -f iso8859-1 -t utf-8 $f >$f.conv
touch -r $f $f.conv
mv $f.conv $f
-Is the BuildRequires: subversion really needed ?
Dank je wel, Hans. All issues should be addressed now, both MUST and SHOULD. Spec URL: http://fedorapeople.org/~iarnell/review/grfcodec.spec SRPM URL: http://fedorapeople.org/~iarnell/review/grfcodec-0.9.11-0.2.r2111.fc12.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334072 (In reply to comment #2) > Dank je wel, Hans. > > All issues should be addressed now, both MUST and SHOULD. > > Spec URL: http://fedorapeople.org/~iarnell/review/grfcodec.spec > SRPM URL: > http://fedorapeople.org/~iarnell/review/grfcodec-0.9.11-0.2.r2111.fc12.src.rpm > > Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334072 All looks good now: approved! New Package CVS Request ======================= Package Name: grfcodec Short Description: A suite of programs to modify Transport Tycoon Deluxe's GRF files Owners: iarnell Branches: F-10 F-11 InitialCC: cvs done. grfcodec-0.9.11-0.2.r2111.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/grfcodec-0.9.11-0.2.r2111.fc11 grfcodec-0.9.11-0.2.r2111.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/grfcodec-0.9.11-0.2.r2111.fc10 Thanks for the review! :-) grfcodec-0.9.11-0.2.r2111.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. grfcodec-0.9.11-0.2.r2111.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |