Bug 498781

Summary:	Review Request: perl-Catalyst-Plugin-Setenv - Catalyst::Plugin::Setenv Perl module
Product:	[Fedora] Fedora	Reporter:	Iain Arnell <iarnell>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Catalyst-Plugin-Setenv/
Whiteboard:
Fixed In Version:	0.03-1.fc10	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-05-04 05:57:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Iain Arnell 2009-05-03 10:24:58 UTC

Spec URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Plugin-Setenv.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Plugin-Setenv-0.03-1.fc12.src.rpm

Description:
perl Build.PL ./Build ./Build test ./Build install

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1333726

*rt-0.09

Comment 1 Parag AN(पराग) 2009-05-03 15:36:36 UTC

Review:
+ package builds in mock (rawhide i586).
lkoji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1333726
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0c4b9383741e71a2fcad20b2298c3855  Catalyst-Plugin-Setenv-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
Files=5, Tests=13,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.32 cusr  0.06 csys =  0.42 CPU)
+ Package perl-Catalyst-Plugin-Setenv-0.03-1.fc12.noarch ->
Provides: perl(Catalyst::Plugin::Setenv) = 0.03
Requires: perl(MRO::Compat) perl(strict) perl(warnings)


 APPROVED.

Comment 2 Iain Arnell 2009-05-03 15:56:48 UTC

New Package CVS Request
=======================
Package Name: perl-Catalyst-Plugin-Setenv
Short Description: Catalyst::Plugin::Setenv Perl module
Owners: iarnell
Branches: F-10 F-11
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-05-04 03:53:45 UTC

cvs done.

Comment 4 Fedora Update System 2009-05-04 05:49:48 UTC

perl-Catalyst-Plugin-Setenv-0.03-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Setenv-0.03-1.fc11

Comment 5 Fedora Update System 2009-05-04 05:49:52 UTC

perl-Catalyst-Plugin-Setenv-0.03-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Setenv-0.03-1.fc10

Comment 6 Iain Arnell 2009-05-04 05:57:58 UTC

Thanks for the review! :-)

Comment 7 Fedora Update System 2009-05-14 02:52:15 UTC

perl-Catalyst-Plugin-Setenv-0.03-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2009-05-14 02:58:17 UTC

perl-Catalyst-Plugin-Setenv-0.03-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.