Bug 498805

- Optflags are not used. Use
 make CFLAGS="%{optflags}" %{?_smp_mflags}

- What is the stuff the package installs in %{_datadir} that you remove?

Once you've fixed these I'll review the package.

(In reply to comment #1)
> - Optflags are not used. Use
>  make CFLAGS="%{optflags}" %{?_smp_mflags}

fixed
 
> - What is the stuff the package installs in %{_datadir} that you remove?

doc files

> Once you've fixed these I'll review the package.  

Thanks

Here are the updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/wavemon.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/wavemon-0.6-2.fc10.src.rpm

rpmlint output is clean.

MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK
MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

The package has been

APPROVED

Thanks for the review.

New Package CVS Request
=======================
Package Name: wavemon
Short Description: Ncurses-based monitoring application for wireless network devices
Owners: fab
Branches: F-9 F-10 F-11
InitialCC:

cvs done.

wavemon-0.6-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/wavemon-0.6-2.fc10

wavemon-0.6-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/wavemon-0.6-2.fc9

wavemon-0.6-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/wavemon-0.6-2.fc11

wavemon-0.6-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update wavemon'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4334

wavemon-0.6-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update wavemon'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4357

wavemon-0.6-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update wavemon'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-4523

wavemon-0.6.5-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/wavemon-0.6.5-1.fc10

wavemon-0.6.5-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/wavemon-0.6.5-1.fc9

wavemon-0.6.5-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/wavemon-0.6.5-1.fc11

wavemon-0.6.5-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

wavemon-0.6.5-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

wavemon-0.6.5-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: wavemon
New Branches: el6
Owners: fab

Git done (by process-git-requests).

Package Change Request
======================
Package Name: wavemon
New Branches: epel7
Owners: fab 
InitialCC:

Git done (by process-git-requests).