Bug 498838 (perl-Any-Moose)
| Summary: | Review Request: perl-Any-Moose - Use Moose or Mouse automagically | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting, tremble |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Any-Moose | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-04 22:43:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 498564 | ||
|
Description
Chris Weyl
2009-05-03 20:27:55 UTC
+ source files match upstream. d159b8b99180599ecc618078c93f3501da8c1469 Any-Moose-0.07.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text is included. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1334395 + package installs properly. + rpmlint has no complaints: perl-Any-Moose.src: I: checking perl-Any-Moose.noarch: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(Any::Moose) = 0.07 perl-Any-Moose = 0.07-1.fc12 = rpm -qp --requires perl-Any-Moose-0.07-1.fc12.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Mouse) >= 0.20 perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 + %check is present and all tests pass. All tests successful. Files=13, Tests=49, 5 wallclock secs ( 0.09 usr 0.01 sys + 4.76 cusr 0.14 csys = 5.00 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED. New Package CVS Request ======================= Package Name: perl-Any-Moose Short Description: Use Moose or Mouse automagically Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig cvs done. Thanks for the review! :-) Package Change Request ====================== Package Name: perl-MooseX-Types New Branches: EL-6 Owners: tremble cweyl has previously expressed that he is happy for others to request EPEL branches There already seems to be a el6 branch here, and you own it. ;) Urgh, copy & paste error https://admin.fedoraproject.org/pkgdb/acls/name/perl-Any-Moose Package Change Request ====================== Package Name: perl-Any-Moose New Branches: EL-6 Owners: tremble Git done (by process-git-requests). |