Bug 498845

This builds fine and rpmlint is silent except for the two complaints that it always spews for R packages.

The license is a bit unclear.  DESCRIPTION says "GPL-2", but src/pijt.c (the only other file that seems to have a license uses the FSF-recommended language and says GPLv2+.

Can you clarify with upstream whether the code is GPLv2 only or GPLv2+?  Upstream seems to be active.

Why is the %check section commented out?

* source files match upstream.  sha256sum:
   7dd0e5ce54e67afe7ea40b0ad127b270c7e822a29aaa3e7373fe465bb361026f  
   msm_0.8.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
? license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   msm.so()(64bit)
   R-msm = 0.8.2-1.fc11
   R-msm(x86-64) = 0.8.2-1.fc11
  =
   /bin/sh
   R
   libR.so()(64bit)
   libRblas.so()(64bit)
   libRlapack.so()(64bit)
   libgfortran.so.3()(64bit)

? %check is present but commented out.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets are OK (R package registration)
* code, not content.

I have contacted upstream for the license issue, and shall keep you updated.
(as a reminder, the upstream Web site is: http://cran.r-project.org/web/packages/msm/index.html)

That's not the URL you have in your spec, but it really should be.

Following is the answer from upstream (C. Jackson):
"Thanks for pointing that out, it was an oversight. I will alter the DESCRIPTION file to put the whole package under GPL version 2 or later. I'm working on several updates and bug fixes at the moment, so I intend to release the next version with this change within the next two weeks."

So, I shall update the specification file accordingly (hopefully this week-end), and re-deliver the new upstream version when available.

If you want to release before those upstream cleanups are done, just include the correspondence clarifying the license as a %doc file in the package.

1. The README_License_msm file (http://denisarnaud.fedorapeople.org/R/msm/082/2/README_License_msm) has been added, with the correspondence clarifying the license issue: that package follows GPLv2+.

2. The URL has been changed, so as to reflect the actual Web site of the R-msm package (http://cran.r-project.org/web/packages/msm/index.html).

3. The %check was commented... because I forgot to uncomment it (I usually first test building packages without enabling the tests, as they take a lot of time) :)

The new RPM package proposal is therefore below:
-------------------------------------------------------------------------------
Spec URL: http://denisarnaud.fedorapeople.org/R/msm/082/2/R-msm.spec
SRPM URL: http://denisarnaud.fedorapeople.org/R/msm/082/2/R-msm-0.8.2-2.fc10.src.rpm

(to check the differences, the older versions are to be found at the following location: http://denisarnaud.fedorapeople.org/R/msm/082/1/)
-------------------------------------------------------------------------------

OK, this builds fine, the check section passes and the license clarification is fine.

APPROVED

New Package CVS Request
=======================
Package Name: R-msm
Short Description: Multi-state Markov and hidden Markov models in continuous time
Owners: denisarnaud
Branches: EL-4 EL-5 F-10 F-11 F-12
InitialCC:

We're still several months away from making F-12 branches for anything.

Otherwise, CVS done.

R-msm-0.9.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/R-msm-0.9.1-1.fc11

R-msm-0.9.1-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/R-msm-0.9.1-1.fc10

R-msm-0.9.1-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

R-msm-0.9.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: R-msm
New Branches: F12
Owners: denisarnaud

cvs done.