Bug 499050

Summary: Review Request: perl-Daemon-Generic - Framework to provide start/stop/reload for a daemon
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.61-1.fc10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-16 01:28:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 499103    
Bug Blocks:    

Description Emmanuel Seyman 2009-05-04 23:49:46 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Daemon-Generic/perl-Daemon-Generic.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Daemon-Generic/perl-Daemon-Generic-0.51-1.fc10.src.rpm
Description:
Daemon::Generic provides a framework for starting, stopping, reconfiguring
daemon-like programs. The framework provides for standard commands that
work for as init.d files and as apachectl-like commands.

Comment 1 Parag AN(पराग) 2009-05-05 04:26:44 UTC
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1336251

DEBUG util.py:256:  No Package Found for perl(File::Flock)

Comment 2 Emmanuel Seyman 2009-05-05 08:29:16 UTC
(In reply to comment #1)
>
> DEBUG util.py:256:  No Package Found for perl(File::Flock)  

I have no idea how mock was able to build this package without perl-File-Flock being available. That review is bug #499103.

Comment 3 Parag AN(पराग) 2009-05-08 17:22:40 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1343552
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
68129579330a63296474101f0cd51dfb86f9f671  Daemon-Generic-0.51.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
No tests defined for Daemon::Generic extension.
+ Package perl-Daemon-Generic-0.51-1.fc12.noarch =>
Provides: perl(Daemon::Generic) = 0.51 perl(Daemon::Generic::Event) = 0.3 perl(Daemon::Generic::While1) = 0.3
Requires: perl(Carp) perl(Daemon::Generic) perl(Event) perl(Exporter) perl(File::Flock) perl(File::Slurp) perl(Getopt::Long) perl(POSIX) perl(strict) perl(warnings)

APPROVED.

Comment 4 Emmanuel Seyman 2009-05-08 20:40:36 UTC
Thanks, Parag!

New Package CVS Request
=======================
Package Name: perl-Daemon-Generic
Short Description: Framework to provide start/stop/reload for a daemon
Owners: eseyman
Branches: F-9 F-10 F-11
InitialCC: perl-sig

Comment 5 Kevin Fenzi 2009-05-09 20:59:00 UTC
cvs done.

Comment 6 Parag AN(पराग) 2009-05-13 06:29:41 UTC
is this built?

Comment 7 Fedora Update System 2009-05-13 15:57:40 UTC
perl-Daemon-Generic-0.61-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Daemon-Generic-0.61-1.fc10

Comment 8 Fedora Update System 2009-05-14 02:53:16 UTC
perl-Daemon-Generic-0.61-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Daemon-Generic'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4935

Comment 9 Fedora Update System 2009-06-16 01:28:01 UTC
perl-Daemon-Generic-0.61-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.