Bug 499093
| Summary: | Review Request: perl-HTML-WikiConverter - Perl module to convert HTML to wiki markup | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade, terje.rosten |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/HTML-WikiConverter/ | ||
| Whiteboard: | |||
| Fixed In Version: | 0.68-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-07 03:44:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Iain Arnell
2009-05-05 07:42:21 UTC
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1336414 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 34cb8ab7f5375aa7836325f9388d6ffe63c475eb HTML-WikiConverter-0.68.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=71, 2 wallclock secs ( 0.07 usr 0.01 sys + 1.07 cusr 0.08 csys = 1.23 CPU) + Package perl-HTML-WikiConverter-0.68-1.fc12.noarch => Provides: perl(HTML::WikiConverter) = 0.68 perl(HTML::WikiConverter::Normalizer) perl(HTML::WikiConverter::WebApp) Requires: perl(CSS) perl(Carp) perl(DirHandle) perl(Encode) perl(File::Spec) perl(HTML::Element) perl(HTML::Entities) perl(HTML::Tagset) perl(HTML::TreeBuilder) perl(HTML::WikiConverter) perl(HTML::WikiConverter::Normalizer) perl(Params::Validate) perl(Tie::IxHash) perl(URI) perl(URI::Escape) perl(XML::Writer) perl(base) perl(strict) perl(warnings) + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: perl-HTML-WikiConverter Short Description: Perl module to convert HTML to wiki markup Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig cvs done. perl-HTML-WikiConverter-0.68-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-HTML-WikiConverter-0.68-1.fc11 perl-HTML-WikiConverter-0.68-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-HTML-WikiConverter-0.68-1.fc10 Thanks for the review! :-) Too late now, however did you see this? https://bugzilla.redhat.com/show_bug.cgi?id=302271 (In reply to comment #7) > Too late now, however did you see this? > > https://bugzilla.redhat.com/show_bug.cgi?id=302271 can you brief what's too late and what should I see in bug302271? I also see review 302261 is completed state. (In reply to comment #7) > Too late now, however did you see this? Yes - thanks for the hint to make separate html2wiki sub-package ;) I figured you weren't interested in this anymore since you never re-opened it after finally getting to import perl-CSS. perl-HTML-WikiConverter-0.68-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. perl-HTML-WikiConverter-0.68-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |