Bug 499148

Summary: cert.h doesn't have valid functions prototypes
Product: Red Hat Enterprise Linux 5 Reporter: Jan Friesse <jfriesse>
Component: nssAssignee: Kai Engert (:kaie) (inactive account) <kengert>
Status: CLOSED UPSTREAM QA Contact: BaseOS QE <qe-baseos-auto>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3CC: fdinitto, mitr
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-07 20:01:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch fixing this problem none

Description Jan Friesse 2009-05-05 12:07:08 UTC
Created attachment 342444 [details]
Patch fixing this problem

Description of problem:
cert.h doesn't have valid function prototypes. For example CERT_GetPKIXVerifyNistRevocationPolicy() should be CERT_GetPKIXVerifyNistRevocationPolicy(void). Attached patch will say you more.

Version-Release number of selected component (if applicable):
nss-devel-3.12.2.0-4.el5

How reproducible:
always

Steps to Reproduce:
1. write main.c with
#include <cert.h>

int main(void) {
  return 0;
}

2.

gcc `pkg-config --libs --cflags nss` -Wstrict-prototypes main.c

  
Actual results:
/usr/include/nss3/cert.h:1608: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1614: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1620: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1654: warning: function declaration isn’t a prototype

Expected results:
No warnings displayed

Additional info:
Patch included.

Comment 1 Kai Engert (:kaie) (inactive account) 2009-05-07 20:01:37 UTC
Thanks for the report.

Bug forwarded to upstream:
https://bugzilla.mozilla.org/show_bug.cgi?id=491919

I assume you can wait until upstream fixes this warning.
Closing as upstream.