Bug 499476

I remembered why I didn't name this python-orbited... there is a separate pyorbited package that is the client bits. To minimize confusion, I've renamed it to orbited. No other changes were made.

New SPEC: http://www.auroralinux.org/people/spot/review/new/orbited.spec
New SRPM: http://www.auroralinux.org/people/spot/review/new/orbited-0.7.9-1.fc11.src.rpm

Koji Scratch Build (F12): http://koji.fedoraproject.org/koji/taskinfo?taskID=1339097

Doesn't this need an initscript to start the daemon?  What about the config file in /etc/orbited.cfg?

Ping?
could you please add the daemon and config file.
http://www.orbited.org/wiki/Deployment

Once I see this activity to verify this is not stale I will start the review.

(In reply to comment #2)
> Doesn't this need an initscript to start the daemon?  What about the config
> file in /etc/orbited.cfg?  

Yes, I think this would be a good idea.

Okay, lemme see what I can whip up (now that chromium is pushed).

We'd need for orbited to have some support of running as a daemon to do this right. Luke and I whipped up something and he is going to run it past upstream.

I sent a modified version of spots patch upstream for inclusion.  I also tested the patch locally, and it seems to do the trick.

http://groups.google.com/group/orbited-users/browse_thread/thread/2fe09fefb9295421

http://lmacken.fedorapeople.org/rpms/orbited-0.7.10-1.fc11.src.rpm
http://lmacken.fedorapeople.org/rpms/orbited.spec

* Wed Oct 07 2009 Luke Macken <lmacken> - 0.7.10-1
- Update to 0.7.10
- Apply a patch to add a --daemon argument

* Sat Aug 08 2009 Luke Macken <lmacken> - 0.7.9-2
- Ship a working version of urlparse for Orbited on RHEL5
  http://orbited.org/ticket/24

X Daemon
There is still need for some initscript/upstart-integration and config-file as discussed earlier.
It is a standalone daemon, is it?

X User
As noted in http://www.orbited.org/browser/trunk/daemon/orbited.cfg, the daemon can fall back to some user, so it might be good to add an appropriate user.

X SPEC: Wrong indentation of Source1 and Patch0

X KOJI: Ok.

X RPMLINT:
$ rpmlint -v /home/fabiand/Downloads/orbited-0.7.10-1.fc12.*
orbited.noarch: I: checking
orbited.noarch: W: spelling-error-in-summary en_US javascript
orbited.noarch: W: spelling-error-in-summary en_US tcp
orbited.noarch: W: spelling-error-in-description en_US plugins
orbited.noarch: W: no-documentation
orbited.src: I: checking
orbited.src: W: spelling-error-in-summary en_US javascript
orbited.src: W: spelling-error-in-summary en_US tcp
orbited.src: W: spelling-error-in-description en_US plugins
orbited.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 4)
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
- Correct spelling
- Add documentation

Note: This is my first review, thanks for some constructive feedback :)

Seems this also needs python-setuptools:

/usr/bin/orbited -c orbited.cfg
Traceback (most recent call last):
  File "/usr/bin/orbited", line 5, in ?
    from pkg_resources import load_entry_point
ImportError: No module named pkg_resources

http://lmacken.fedorapeople.org/rpms/orbited-0.7.10-2.fc11.src.rpm
http://lmacken.fedorapeople.org/rpms/orbited.spec

* Fri Nov 13 2009 Luke Macken <lmacken> - 0.7.10-2
- Add an init script
- Add the default configuration file
- Patch the default config to enable epoll and to disable access
- Remove python-demjson requirement
- Require python-setuptools

Alright, it looks like the necessary changes have been made, and I note that you have passed the daemon patch to upstream 
http://groups.google.com/group/orbited-users/browse_thread/thread/2fe09fefb9295421/cf1ffe4e4c795e4d?lnk=gst&q=daemon#cf1ffe4e4c795e4d 

I APPROVE this package, please request CVS now.

A quick rpmlint gives:
$ rpmlint orbited-0.7.10-2.fc11.src.rpm 
orbited.src: W: strange-permission orbited.init 0775
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

New Package CVS Request
=======================
Package Name: orbited
Short Description: A browser(javascript)->tcp bridge 
Owners: lmacken
Branches: F-11 F-12 EL-5

(In reply to comment #13)
> A quick rpmlint gives:
> $ rpmlint orbited-0.7.10-2.fc11.src.rpm 
> orbited.src: W: strange-permission orbited.init 0775
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.  

I'll fix that before I commit it to CVS, thanks.

cvs done.

orbited-0.7.10-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/orbited-0.7.10-3.fc12

orbited-0.7.10-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/orbited-0.7.10-3.el5

orbited-0.7.10-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/orbited-0.7.10-3.fc11

orbited-0.7.10-3.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update orbited'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0030

orbited-0.7.10-3.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update orbited'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0281

orbited-0.7.10-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update orbited'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0315

orbited-0.7.10-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

orbited-0.7.10-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.