Bug 499491

Summary:	Review Request: libtdb - spin off of samba4 package
Product:	[Fedora] Fedora	Reporter:	Simo Sorce <ssorce>
Component:	Package Review	Assignee:	Matthew Barnes <mbarnes>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mbarnes, notting, sgallagh
Target Milestone:	---	Flags:	mbarnes: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-06-19 16:51:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Simo Sorce 2009-05-06 20:55:19 UTC

Spec URL: http://simo.fedorapeople.org/libtdb/libtdb.spec
SRPM URL: http://simo.fedorapeople.org/libtdb/libtdb-1.1.3-0.fc11.src.rpm
Description: Spin off libtdb from the samba4 package into its own now that
upstream has finally released a separate tarball.
The package name and versioning is consistent with what was provided by the
samba4 package so dropping this in and disabling building "tdb" from the
samba4 package should provide a seamless migration path

Comment 1 Matthew Barnes 2009-05-08 18:03:10 UTC

I got a build error with this:

  error: Installed (but unpackaged) file(s) found:
     /usr/lib/python2.6/site-packages/tdb.so

rpmlint output:

libtdb.src: I: checking
libtdb.src:58: E: files-attr-not-set
libtdb.src:59: E: files-attr-not-set
libtdb.src:60: E: files-attr-not-set
libtdb.src:63: E: files-attr-not-set
libtdb.src:64: E: files-attr-not-set
libtdb.src:65: E: files-attr-not-set
libtdb.src:68: E: files-attr-not-set
libtdb.src:69: E: files-attr-not-set
libtdb.src:71: E: files-attr-not-set
libtdb.src:72: E: files-attr-not-set

Issues to resolve:

- Missing Requires: pkgconfig.
- devel and tdb-tools files are missing a %defattr.
- Add missing Python library or disable Python bindings.

Comment 2 Simo Sorce 2009-05-08 22:59:13 UTC

Ok uploaded new spec and srpm

The python bindings are not normally built in mock/koji as python devel stuff is not listed in devel dependencies but I removed the file as a convenience for people that rebuilds on their machine.

Fixed Requires
Fixed %defattr

Comment 3 Matthew Barnes 2009-05-09 02:35:51 UTC

Looks okay to me.  Approved.

Comment 4 Simo Sorce 2009-05-09 14:20:13 UTC

New Package CVS Request
=======================
Package Name: libtdb
Short Description: A library that implements a trivial database.
Owners: simo gd
Branches: F11
InitialCC:

Comment 5 Kevin Fenzi 2009-05-09 21:05:06 UTC

cvs done.

Comment 6 Matthew Barnes 2009-06-19 16:51:02 UTC

Closing this.

Comment 7 Stephen Gallagher 2010-02-23 18:56:45 UTC

Package Change Request
======================
Package Name: libtdb
New Branches: EL-5
Owners: sgallagh

This is being branched in preparation for building the SSSD in EPEL. (libtdb is a dependency)

I have simo's permission to become the EPEL maintainer for this package.

Comment 8 Jason Tibbitts 2010-02-23 20:01:10 UTC

CVS done.

Comment 9 Fedora Update System 2010-02-23 20:42:33 UTC

libtdb-1.2.0-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libtdb-1.2.0-1.el5