Bug 499493
| Summary: | run tps under valgrind | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Dogtag Certificate System | Reporter: | Chandrasekar Kannan <ckannan> | ||||||||||||
| Component: | TPS | Assignee: | Jenny Severance <jgalipea> | ||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Chandrasekar Kannan <ckannan> | ||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||
| Priority: | urgent | ||||||||||||||
| Version: | unspecified | CC: | alee, awnuk, benl, cfu, jgalipea, jmagne | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2009-07-22 23:35:04 UTC | Type: | --- | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Bug Depends On: | |||||||||||||||
| Bug Blocks: | 443788 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chandrasekar Kannan
2009-05-06 21:00:02 UTC
[builder@dhcp231-124 dogtag-src]$ svn ci -m "Bugzilla Bug #499493 - run tps under valgrind" pki/dogtag/tps pki/base/tps Sending pki/base/tps/src/authentication/LDAP_Authentication.cpp Sending pki/base/tps/src/cms/CertEnroll.cpp Sending pki/base/tps/src/engine/RA.cpp Sending pki/base/tps/src/include/engine/RA.h Sending pki/base/tps/src/modules/tokendb/mod_tokendb.cpp Sending pki/base/tps/src/modules/tps/AP_Session.cpp Sending pki/base/tps/src/msg/RA_Extended_Login_Response_Msg.cpp Sending pki/base/tps/src/processor/RA_Enroll_Processor.cpp Sending pki/base/tps/src/processor/RA_Format_Processor.cpp Sending pki/base/tps/src/processor/RA_Pin_Reset_Processor.cpp Sending pki/base/tps/src/processor/RA_Processor.cpp Sending pki/base/tps/src/tus/tus_db.c Sending pki/dogtag/tps/pki-tps.spec Transmitting file data ............. Committed revision 500. Jenny, Please rerun the test and add the argument --leak-check=full to the set of arguments to valgrind. This will provide the information I need to see where the leaks you found occur. sure! Created attachment 349870 [details]
Valgrind logs with full leak check
Attaching valgrind logs with full leak check enabled.
Ade, this patch looks good. One caveat, there is a specific function you can use to free a SECItem. Look here: http://www.mozilla.org/projects/security/pki/nss/ref/ssl/ssltyp.html#1030620 Take a look at that and see if it would better fit the bill for deleting that signedResult variable. Attachement: (id=350138) +jmagne. Jack's change added .. [builder@dhcp231-124 pki]$ svn ci -m "Bugzilla Bug #499493 - Run TPS under valgrind" base/tps dogtag/tps Sending base/tps/src/engine/RA.cpp Sending base/tps/src/main/ConfigStore.cpp Sending dogtag/tps/pki-tps.spec Transmitting file data ... Committed revision 666. Created attachment 350630 [details]
valgrind logs startup with no signing
attached valgrind logs - startup with no signing
Created attachment 350631 [details]
valgrind logs restart log signing enabled
valgrind logs restart with log signing enabled.
Created attachment 350632 [details]
valgrind logs tpsclient activitiy
valgrind logs with tpsclient activity
1. restart tps
2. format token
3. enroll token
4. reset pin
Created attachment 350633 [details]
valgrind logs admin activity
valgrind logs with admin activity:
1. restart tps with log signing
2. list/search tokens
3. add token
4. add user
5. edit user add all profiles
6. edit token re-enroll
7. delete token
8. delete user
9. list/search/delete activity
10. edit audit signing configuration - selected events
after looking at the logs uploaded by Jenny - confirmed that the only leaks observed are those on startup. Recommend that we close this bug as verified and clone as a medium priority bug for 8.1 to fix startup leaks. Verified: remaining leaks are in startup and being address by bug 481670 - see attached valgrind logs |