Bug 499880
| Summary: | tomoe-gtk not built with $RPM_OPT_FLAGS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | tomoe-gtk | Assignee: | Ding-Yi Chen <dchen> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 11 | CC: | dchen, i18n-bugs, ryo-dairiki | ||||
| Target Milestone: | --- | Keywords: | Patch, Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.6.0-11.fc11 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-08-31 23:42:46 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 496968 | ||||||
| Attachments: |
|
||||||
|
Description
Ville Skyttä
2009-05-08 17:50:50 UTC
Thanks for informing me and providing patch for this bug. However, I tend not to apply patches on generated sources. Anyway, I will submit the patch to the upstream. tomoe-gtk-0.6.0-7.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-7.fc11 tomoe-gtk-0.6.0-7.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-7.fc10 tomoe-gtk-0.6.0-7.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4984 tomoe-gtk-0.6.0-7.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-5022 This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle. Changing version to '11'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping tomoe-gtk-0.6.0-7.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. tomoe-gtk-0.6.0-7.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. (In reply to comment #1) > Thanks for informing me and providing patch for this bug. > However, I tend not to apply patches on generated sources. > Anyway, I will submit the patch to the upstream. Hmm, was your intention to drop the patch altogether or create a corresponding one for non-generated sources? The package is not currently built with $RPM_OPT_FLAGS even though the changelog entries for 0.6.0-6 and 0.6.0-7 say so -> reopening. http://kojipkgs.fedoraproject.org/packages/tomoe-gtk/0.6.0/7.fc11/data/logs/x86_64/build.log tomoe-gtk-0.6.0-8.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-8.fc11 tomoe-gtk-0.6.0-8.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-8.fc10 The bug is still not fixed; the only changes between -7.fc* and -8.fc* are cosmetic. See comment 9. http://cvs.fedoraproject.org/viewvc/rpms/tomoe-gtk/F-11/tomoe-gtk.spec?r1=1.5&r2=1.6 http://kojipkgs.fedoraproject.org/packages/tomoe-gtk/0.6.0/8.fc11/data/logs/x86_64/build.log Sorry, I forgot to add back the Buildrequire: autoconf, automake http://koji.fedoraproject.org/koji/taskinfo?taskID=1477780 Does it works for you now? Regards, No, it's still not fixed. Again, please see comment 9: you have dropped the part of my original patch that actually fixes the problem of CFLAGS being discarded: python_disable_message="Disable Python binding." + _SAVE_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS $PYTHON_CFLAGS" It's easy to verify from the build logs whether $RPM_OPT_FLAGS are in use, for example the first gcc line from http://koji.fedoraproject.org/koji/getfile?taskID=1477780&name=build.log: /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/tomoe -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DSYSCONFDIR=\""/etc"\" -DDATADIR=\""/usr/share"\" -DTOMOEGTKDATADIR=\""/usr/share"/tomoe-gtk\" -c -o tomoe-canvas.lo tomoe-canvas.c There are no $RPM_OPT_FLAGS in it. There should be stuff like "-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector ..." tomoe-gtk-0.6.0-8.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7771 tomoe-gtk-0.6.0-8.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7791 tomoe-gtk-0.6.0-11.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-11.fc11 tomoe-gtk-0.6.0-11.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-11.fc10 tomoe-gtk-0.6.0-11.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8411 tomoe-gtk-0.6.0-11.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8448 tomoe-gtk-0.6.0-11.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. tomoe-gtk-0.6.0-11.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |