Bug 499942
| Summary: | PATCH: alsa output plugin fixes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | audacious-plugins | Assignee: | Ralf Ertzinger <redhat-bugzilla> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 11 | CC: | bugs.michael, hk, redhat-bugzilla |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.5.1-6.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-27 02:45:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Hans de Goede
2009-05-09 10:25:41 UTC
Ok, so I've been testing this some more and my second patch attached to: http://redmine.atheme.org/issues/show/60 Had some issues, I've filed a new set of patches here: http://redmine.atheme.org/issues/show/61 However those are against the 2.0 mercurial tree. I initially developed them against 1.5.1, so I'll attach the original versions here. Please apply these do the Fedora package, without them when using the alsa output with the latest pulse alsa plugin (which is the default setup). audacious often hangs (on my system). The locking in the alsa output plugin without this patch is non existent, and that while there are separate reader / writer threads both manipulating the rd / wr indexes of a fifo. Created attachment 343642 [details]
alsa plugin: Fix last second(s) of songs getting lost
Created attachment 343643 [details]
Fix alsa plugin locking
Created attachment 343644 [details]
alsa output plugin: allow usage of last byte of thread buffer
Created attachment 343645 [details]
alsa output plugin: use snd_pcm_recover()
This last patch is a bit of an optional cleanup I did while I was at it.
*** Bug 498885 has been marked as a duplicate of this bug. *** audacious-plugins-1.5.1-6.fc10,audacious-1.5.1-9.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/audacious-plugins-1.5.1-6.fc10,audacious-1.5.1-9.fc10 This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle. Changing version to '11'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping audacious-plugins-1.5.1-6.fc11, audacious-1.5.1-9.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update audacious-plugins audacious'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6438 audacious-plugins-1.5.1-6.fc10, audacious-1.5.1-9.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update audacious-plugins audacious'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-6490 audacious-plugins-1.5.1-6.fc11, audacious-1.5.1-9.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. audacious-plugins-1.5.1-6.fc10, audacious-1.5.1-9.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |