Bug 500191 (perl-Crypt-Twofish)

Summary: Review Request: perl-Crypt-Twofish - Twofish Encryption Algorithm
Product: [Fedora] Fedora Reporter: Iain Arnell <iarnell>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Crypt-Twofish/
Whiteboard:
Fixed In Version: 2.13-1.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-13 15:05:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Iain Arnell 2009-05-11 15:25:07 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Crypt-Twofish.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Crypt-Twofish-2.13-1.fc12.src.rpm

Description:
Twofish is a 128-bit symmetric block cipher with a variable length (128,
192, or 256-bit) key, developed by Counterpane Labs. It is unpatented and
free for all uses, as described at http://www.counterpane.com/twofish.html.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1347925

*rt-0.09

Comment 1 Parag AN(पराग) 2009-05-12 03:56:19 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1347925
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0560b227a1a0de2755412b09b56608a9e0407d75  Crypt-Twofish-2.13.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
+ Package perl-Crypt-Twofish-2.13-1.fc12.i586 =>
Provides: perl(Crypt::Twofish) = 2.13
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) perl(Carp) perl(DynaLoader) perl(strict) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH)

APPROVED.

Comment 2 Iain Arnell 2009-05-12 04:45:57 UTC
New Package CVS Request
=======================
Package Name: perl-Crypt-Twofish
Short Description: Twofish Encryption Algorithm
Owners: iarnell
Branches: F-10 F-11
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-05-13 05:00:15 UTC
cvs done.

Comment 4 Fedora Update System 2009-05-13 15:10:13 UTC
perl-Crypt-Twofish-2.13-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Crypt-Twofish-2.13-1.fc11

Comment 5 Fedora Update System 2009-05-13 15:10:19 UTC
perl-Crypt-Twofish-2.13-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Crypt-Twofish-2.13-1.fc10

Comment 6 Fedora Update System 2009-05-25 21:07:26 UTC
perl-Crypt-Twofish-2.13-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2009-05-25 21:19:10 UTC
perl-Crypt-Twofish-2.13-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.