Bug 500824

Summary: Possible missing runtime dependencies for `ecryptfs-setup-swap'
Product: Red Hat Enterprise Linux 5 Reporter: Michal Nowak <mnowak>
Component: ecryptfs-utilsAssignee: Michal Hlavinka <mhlavink>
Status: CLOSED ERRATA QA Contact: BaseOS QE <qe-baseos-auto>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.4CC: ohudlick, rvokal
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-02 09:56:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michal Nowak 2009-05-14 12:36:30 UTC
Description of problem:

/usr/bin/ecryptfs-setup-swap utilizes 

* /sbin/cryptsetup (cryptsetup-luks pkg) via

    # Ensure that cryptsetup is available
    [ -x /sbin/cryptsetup ] || error "Please install 'cryptsetup'"

(a little bit strange is that `cryptsetup' is never called afterwards)

* /sbin/dmsetup (device-mapper pkg) via

    # Check if this this swap space is already setup for encryption
    if /sbin/dmsetup table "$swap" | grep -qs " crypt " 2>/dev/null; then
            info "[$swap] already appears to be encrypted."
            exit 0
    else
    [...]

but does not depend on them (= rpm dependency). It might be a good idea to have explicit dependency in spec file.

Version-Release number of selected component (if applicable):

ecryptfs-utils-75-1.el5

Comment 1 Michal Hlavinka 2009-05-18 09:33:26 UTC
yum remove device-mapper #contains dmsetup
....
-> dependency would remove coreutils

but this can be easily added to ecryptfs-utils

* /sbin/cryptsetup (cryptsetup-luks pkg) via
(a little bit strange is that `cryptsetup' is never called afterwards)

it's not called but it's used later with dmsetup if you want to encrypt device

requiring cryptsetup seem little bit odd from my POV, but since it'd be "always" present (hal requires cryptsetup), it makes no difference.

Comment 2 Michal Hlavinka 2009-05-18 14:33:10 UTC
only minor change in spec file

Comment 7 errata-xmlrpc 2009-09-02 09:56:57 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1307.html