Bug 501498

OK it seems that my description got lost...

Here is a new try:

Spec URL: http://www.ultrafredde.com/projects/task.spec
SRPM URL: http://www.ultrafredde.com/projects/task-1.7.0-1.fc10.src.rpm

Hi there!

I have packaged task, an command-line TODO list manager.

The Spec and SRPM are based on the latest release of the upstream package, that is 1.7.0.

The rpmlint runs are error and warning free.

It would be nice to get a review as well as sponsoring to get task into Fedora.

As further information I want to mention that I have close contact to the upstream developer and contribute to the task project (having written the man pages and the bash completion script for the 1.7.0 release).

/Federico

For a beginner you have provide a nice well-suited package. There are
only thwo minor issues which you may fix easily. So I tell you, that I
want to sponsor you, after the package will be approved.

Good:
+ Basename SPEC filename matches which package name
+ Package name fullfill naming guidelines
+ URL tag shows on proper project homepage
+ Package contains most recent stable release of the software
+ Could download upstream tar ball via spectool -g
+ Packaged tar ball matches with upstream
(md5sum: 4f6fe66dbd9fb3249dd201fd843b8319)
+ Package contains proper license tag
+ License tag states GPLv2 as a valid OSS license
+ Consistently rpm macro usage in package
+ Package doesn't contains any subpackage
+ Proper Buildroot defintion
+ Buildroot will be cleaned at the beginning of %clean and %install
+ Package contains verbatin copy of the license text
+ Local build works fine
+ Package support SMP build
+ Build honours RPM_OPT_FLAGS
+ Rpmlint is silient on source rpm
+ Rpmlint is silent on binary rpm
+ Debuginfo package contains sources
+ Local install and uninstall works fine
+ Application doesn't crash on start
+ Koji build works fine
+ Files in the files stanza has proper files permission
+ All packaged files are owned by the pacakge
+ No packaged file is owned by another package
+ %doc stanza is small, so we need no extra doc subpackage
+ Patckage has prpoer %Changelog

Bad:
- Copyright notes in the source files haeaders state GPLv2+
  as license for the package
- You can remove the requires ncurses line, because rpm
  create automaticly a Require to the library

Spec URL: http://www.ultrafredde.com/projects/task.spec
SRPM URL: http://www.ultrafredde.com/projects/task-1.7.0-2.fc10.src.rpm

Hallo Jochen!

Vielen Dank für die Review.

I have now changed the spec file according to your suggestions - from the Changelog section:

* Tue May 19 2009 Federico Hernandez <ultrafredde> - 1.7.0-2
- Changed license to GPLv2+ and removed Requires macro.
- See https://bugzilla.redhat.com/show_bug.cgi?id=501498

New rpmlint runs showed now error nor warnings.

/Federico

Hint. It's ok to wrote '(#501498)' as an abbrevious in the changelog.

Because you package look good. I will APPRROVED you.

You can create a FAS account and done the cla. Please request membership in the packagers group, so I can sponsor you.

Unfortunately, I'm away until sunday.

THX for the changelog abbreviation hint.

FAS account and cla are done and ready. I have requested now requested membership in the packagers group.

Grüsse
Federico

New Package CVS Request
=======================
Package Name: task 
Short Description: An open source, command-line, TODO list manager
Owners: ultrafredde
Branches: F-10 F-11
InitialCC: s4504kr

CVS done.

task-1.7.0-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/task-1.7.0-2.fc10

task-1.7.0-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/task-1.7.0-2.fc11

task-1.7.0-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

task-1.7.0-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Once you sponsor someone, please remember to remove the FE-NEEDSPONSOR tag to
avoid noise in the blocker bug.

Package Change Request
=======================
Package Name: task 
Short Description: An open source, command-line, TODO list manager
Owners: ultrafredde
New Branch: F-12 EL-5

cvs done.

Package Change Request
======================
Package Name: task
New Branches: epel7
Owners: ultrafredde gbailey

Git done (by process-git-requests).

Package Change Request
======================
Package Name: task
New Branches: epel7
Owners: ralph

Git done (by process-git-requests).

(In reply to Ralph Bean from comment #17)
> Package Change Request
> ======================
> Package Name: task
> New Branches: epel7
> Owners: ralph

Just curious what the purpose of this branch creation request is?  There was already an "epel7" branch (and corresponding builds) already...

(In reply to Greg Bailey from comment #19)
> Just curious what the purpose of this branch creation request is?  There was
> already an "epel7" branch (and corresponding builds) already...

Ah, it was a mistake -- the result of some miscommunication in IRC.  :(  Sorry for the noise.