Bug 501895

Summary: Socket is not closed when disconnecting from server
Product: [Fedora] Fedora Reporter: Stefan Becker <chemobejk>
Component: libvncserverAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 11CC: rdieter
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://sourceforge.net/tracker/?func=detail&aid=2794565&group_id=32584&atid=405858
Whiteboard:
Fixed In Version: 0.9.7-2.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-19 23:16:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed patch none

Description Stefan Becker 2009-05-21 08:57:30 UTC 
Description of problem:

libvncclient code does not close the socket when disconnecting from the server. As a result clients that don't exit immediately will leak file descriptors, e.g. KDE's krdc. This is especially annoying when you tunnel VNC connection through SSH, because SSH refuses to close the connection as it thinks there is still an active connection.

I've reported the error upstream (see URL) and supplied a patch.

Version-Release number of selected component (if applicable):
libvncserver-0.9.1-4.fc11

How reproducible:
Always

Steps to Reproduce:
1. netstat -tp | grep krdc
2. start krdc and create a connection to a VNC server
3. netstat -tp | grep krdc
4. close the connection to the the VNC server
5. netstat -tp | grep krdc
  
Actual results:
netstat still shows an open TCP connection owned by krdc

Expected results:
netstat does not show any open TCP connections owned by krdc when there are no VNC connections ongoing.
Comment 1 Rex Dieter 2009-05-21 12:29:02 UTC 
thanks.
Comment 2 Rex Dieter 2009-05-21 12:29:32 UTC 
Created attachment 344954 [details]
proposed patch
Comment 3 Rex Dieter 2009-05-24 04:31:18 UTC 
* Sat May 23 2009 Rex Dieter <rdieter> - 0.9.7-3
- Socket is not closed when disconnecting from server (#501895)
Comment 4 Bug Zapper 2009-06-09 16:13:48 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping
Comment 5 Stefan Becker 2009-08-07 14:41:40 UTC 
Koji shows that the F11 package has been built over two months ago. Any chance that this gets pushed to updates at some point?
Comment 6 Rex Dieter 2009-08-07 15:00:33 UTC 
Ah, true thanks for the reminder, can you confirm the issue is fixed in the newer build?

http://koji.fedoraproject.org/koji/buildinfo?buildID=103459
Comment 7 Fedora Update System 2009-08-07 15:02:25 UTC 
libvncserver-0.9.7-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libvncserver-0.9.7-2.fc11
Comment 8 Fedora Update System 2009-08-07 15:04:06 UTC 
libvncserver-0.9.7-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libvncserver-0.9.7-2.fc11
Comment 9 Rex Dieter 2009-08-07 15:04:48 UTC 
Meh, looks like I botched the Release # (2 vs 3), but it should be mostly harmless.
Comment 10 Fedora Update System 2009-08-08 19:26:06 UTC 
libvncserver-0.9.7-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libvncserver'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8383
Comment 11 Fedora Update System 2009-08-19 23:16:25 UTC 
libvncserver-0.9.7-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.