Bug 502054 (perl-Lingua-Flags)
| Summary: | Review Request: perl-Lingua-Flags - Provide small flag icons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | cweyl:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Lingua-Flags/ | ||
| Whiteboard: | |||
| Fixed In Version: | 0.05-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-27 03:22:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Iain Arnell
2009-05-21 16:13:41 UTC
To quote https://fedoraproject.org/wiki/Package_Maintainers_Flags_Policy <<EOF When a package contains flag images that are used (in the user interface, in documentation, etc.) to represent locations, countries, nations, other kinds of geopolitical entities, languages, other kinds of ethnocultural concepts, religions, political movements and institutions, and the like, and where such use is not technically or substantively essential to the package, those flag images must be placed in an -flags subpackage. The -flags subpackage cannot be Required by the main package. EOF This package may contain flag images, but they are not "used ... to represent" anything at all. And even if they were used, I'm pretty sure that such use is both technically and substantively essential to this package. Looks good. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1368784 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): c2a7512bc98f7c67d014b4646af79e95afa55bdf Lingua-Flags-0.05.tar.gz c2a7512bc98f7c67d014b4646af79e95afa55bdf Lingua-Flags-0.05.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Lingua-Flags-0.05-1.fc12.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Lingua-Flags-0.05-1.fc12.noarch.rpm perl(Lingua::Flags) = 0.05 perl-Lingua-Flags = 0.05-1.fc12 ====> requires for perl-Lingua-Flags-0.05-1.fc12.noarch.rpm perl(base) perl(MIME::Base64) perl(:MODULE_COMPAT_5.10.0) perl(strict) perl(warnings) =====> perl-Lingua-Flags-0.05-1.fc12.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Lingua-Flags-0.05-1.fc12.src.rpm ====> requires for perl-Lingua-Flags-0.05-1.fc12.src.rpm perl(ExtUtils::MakeMaker) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) APPROVED New Package CVS Request ======================= Package Name: perl-Lingua-Flags Short Description: Provide small flag icons Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig CVS done. perl-Lingua-Flags-0.05-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Lingua-Flags-0.05-1.fc11 perl-Lingua-Flags-0.05-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Lingua-Flags-0.05-1.fc10 perl-Lingua-Flags-0.05-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. perl-Lingua-Flags-0.05-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |