Bug 502117
| Summary: | Review Request: mod_log_post - Module for the Apache web server to log all HTTP POST messages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | Package Review | Assignee: | Sven Lankes <sven> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, sven |
| Target Milestone: | --- | Flags: | sven:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.1.0-1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-26 22:44:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert Scheck
2009-05-21 23:08:15 UTC
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format %{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: f11/x86_64
[!] Rpmlint output:
source RPM: empty
mod_log_post.src: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
binary RPM:empty
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:GPLv2 with exceptions
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided in the spec URL.
SHA1SUM of package: 817b86c6040fd64b21b66f7fc7ab6b19926847c8 mod_log_post-0.1.0.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[x] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[-] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[x] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: f10/x86_64
[x] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
Please fix the tab issue in the spec-file before importing.
**** APPROVED ***
Sven, thank you very much for doing the review. Just as a note: I got told by Thorsten and Christoph, that fixes always should happen after import, that these changes can be also tracked by the community. New Package CVS Request ======================= Package Name: mod_log_post Short Description: Module for the Apache web server to log all HTTP POST messages Owners: robert Branches: EL-4 EL-5 F-10 F-11 InitialCC: CVS done. mod_log_post-0.1.0-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mod_log_post-0.1.0-1.fc10 mod_log_post-0.1.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mod_log_post-0.1.0-1.fc11 Package: mod_log_post-0.1.0-1.fc12 Tag: dist-f12 Status: complete Package: mod_log_post-0.1.0-1.fc11 Tag: dist-f11-updates-candidate Status: complete Package: mod_log_post-0.1.0-1.fc10 Tag: dist-f10-updates-candidate Status: complete 2389 (mod_log_post): Build on target fedora-5-epel succeeded. 2390 (mod_log_post): Build on target fedora-4-epel succeeded. mod_log_post-0.1.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. mod_log_post-0.1.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |