Bug 502466

Summary: liveinst rewrites ifcfg-eth0 without NM_CONTROLLED=no
Product: [Fedora] Fedora Reporter: Mads Kiilerich <mads>
Component: anacondaAssignee: David Cantrell <dcantrell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 10CC: rmaximo, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-02 20:26:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
0003-Test-NM_CONTROLLED-setting-correctly-in-network.py.patch none

Description Mads Kiilerich 2009-05-25 11:44:47 UTC 
Description of problem:

AFAICS liveinst rewrites ifcfg-eth0 based on the current values from the running livecd. That is generally very nice.

BUT it leaves out NM_CONTROLLED. That is unexpected and problematic in some cases when creating installable custom livecds (which I was doing).


Version-Release number of selected component (if applicable):

anaconda-11.4.1.63-1.i386
Comment 1 Mads Kiilerich 2009-05-25 12:21:06 UTC 
I notice some awareness of NM_CONTROLLED in /usr/lib/anaconda/network.py, but it seems like it doesn't try to write NM_CONTROLLED.

Probably unrelated, but AFAIK _only_ NM_CONTROLLED=no (case sensitive) has any semantics to NM, so the checks for yes case insensitive or empty is not correct.
Comment 2 David Cantrell 2009-06-02 03:23:42 UTC 
Created attachment 346166 [details]
0003-Test-NM_CONTROLLED-setting-correctly-in-network.py.patch

Patch to preserve NM_CONTROLLED variable on custom live images.  Awaiting patch review.
Comment 3 David Cantrell 2009-06-02 20:26:17 UTC 
Patched committed to master branch in git, will be in the next anaconda build for rawhide.
Comment 4 Mads Kiilerich 2009-06-02 20:50:30 UTC 
Thanks.

I noticed the actual NM parsing is done in
http://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/system-settings/plugins/ifcfg-rh/reader.c#n2105 . Actually both n, no and false can be used. It would be simpler if only one was supported, but perhaps you want to support all of them.