Bug 502596
| Summary: | Review Request: sblim-tools-libra - SBLIM Common Resource Access Library for WBEM-SMT tasks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vitezslav Crhonek <vcrhonek> |
| Component: | Package Review | Assignee: | Praveen K Paladugu <praveen_paladugu> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, matt_domsch, notting, praveen_paladugu, shyam_iyer, wwlinuxengineering |
| Target Milestone: | --- | Flags: | praveen_paladugu:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-20 08:51:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 468400 | ||
|
Description
Vitezslav Crhonek
2009-05-26 11:52:26 UTC
user1# rpmlint sblim-tools-libra.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
user1# sblim-tools-libra-0.2.3-1.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
user1# sblim-tools-libra-0.2.3-1.fc10.i386.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
user1# sblim-tools-libra-devel-0.2.3-1.fc10.i386.rpm
sblim-tools-libra-devel.i386: W: no-documentation
Replace the occurrence of "sblim-tools-libra" with %{name} whenever possible.
Since this package only provides the libraries, it should be Grouped under Libraries instead of Applications.
(In reply to comment #1) > user1# rpmlint sblim-tools-libra.spec > 0 packages and 1 specfiles checked; 0 errors, 0 warnings. > user1# sblim-tools-libra-0.2.3-1.fc10.src.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > user1# sblim-tools-libra-0.2.3-1.fc10.i386.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > user1# sblim-tools-libra-devel-0.2.3-1.fc10.i386.rpm > sblim-tools-libra-devel.i386: W: no-documentation > > Replace the occurrence of "sblim-tools-libra" with %{name} whenever possible. Done. > > Since this package only provides the libraries, it should be Grouped under > Libraries instead of Applications. sblim-tools-libra - System Environment/Libraries sblim-tools-libra-devel - Development/Libraries OK? Ping? Sorry for the delay. Since the release number wasn't changed, I thought the new sources were not available yet. Few more things to take care of: 1) #user1 rpmlint rpmbuild/RPMS/i386/sblim-tools-libra-devel-0.2.3-1.fc10.i386.rpm sblim-tools-libra-devel.i386: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Please add some documentation to doc package. 2) The devel package seems to own /usr/include/sblim directory. I suggest a "Requires:" be added to a package which owns this directory. This is just to make sure that the same directory is not owned by different packages. sblim-cmpi-base-devel seems to be a good choice. Please suggest if you have any other package in mind. Please bump up the release number of the package to avoid further confusion. This package is good to go after handling the above comments. Thank you Praveen In reply to comment #4) > Sorry for the delay. > > Since the release number wasn't changed, I thought the new sources were not > available yet. > > Few more things to take care of: > 1) #user1 rpmlint > rpmbuild/RPMS/i386/sblim-tools-libra-devel-0.2.3-1.fc10.i386.rpm > sblim-tools-libra-devel.i386: W: no-documentation > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > Please add some documentation to doc package. The documentation from upstream tarball is shipped in sblim-tools-libra package, there's no more documentation left for -devel package. Because -devel package requires sblim-tools-libra package to be installed, the documentation will be available to the user. > > 2) The devel package seems to own /usr/include/sblim directory. I suggest a > "Requires:" be added to a package which owns this directory. This is just to > make sure that the same directory is not owned by different packages. > > sblim-cmpi-base-devel seems to be a good choice. Please suggest if you have > any other package in mind. I believe this is not necessary and will lead only to pointless dependency. See https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership IMHO this is the case of second example - Multiple packages have files in a common directory but none of them requires others. > > > Please bump up the release number of the package to avoid further confusion. So I did no changes. Please let me know if you have anything else or if you feel I'm wrong with things above. > > > This package is good to go after handling the above comments. > > Thank you > Praveen Everything looks good. Please go ahead and submit request for CVS. Please add a cvs template here so we know what you would like. https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure New Package CVS Request ======================= Package Name: sblim-tools-libra Short Description: The tools-libra package provides common functionality required by the task-specific resource access layers of wbem-smt tasks such as cmpi-dns and cmpi-samba. Owners: vcrhonek Branches: F-10 F-11 F-12 EL-4 EL-5 I'd have to say that short description isn't very short. ;) cvs done. |