Bug 503148
| Summary: | Review Request: kmess - a msn messenger for kde | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Sievert <caleb> |
| Component: | Package Review | Assignee: | Susi Lehtola <susi.lehtola> |
| Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, sundaram, susi.lehtola |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-22 12:37:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Florian Sievert
2009-05-29 09:21:08 UTC
Some initial notes:
- Is the target platform stuff really necessary? Doesn't a simple
%{cmake_kde4}
make VERBOSE=1 %{?_smp_mflags}
do the job?
- You don't need to use
%setup -q -n %{name}-%{version}
a simple
%setup -q
will do.
- You probably don't need to
mkdir %{buildroot}
as this should be automatically done by make install.
- You must install the desktop file as per
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
- You must handle locale files as per
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
- You need to
Requires: hicolor-icon-theme
for dir ownership.
- You need to update icon cache as per
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
- Explicit requires of libraries (qca2) is not allowed
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- %{_kde4_appsdir}/kmess/icons/hicolor/*/apps/gnomemeeting.png doesn't look correct.
- You're missing the source URL, ref
http://fedoraproject.org/wiki/Packaging/SourceURL
Is this your first package? It should have said so in the review request. Also, I see you have applied for packager group membership. You need a sponsor, which also should have been in the review request and the blocker bug FE-NEEDSPONSOR should have been set. If you do not have a sponsor yet I am willing to sponsor you if you convince me you know the Fedora Packaging guidelines (which, obviously, you don't - at the moment - judging from the amount of problems in the spec file). You will need to submit at least one another package for review, and perform initial reviews of packages of other people. ping? ping one more time Closing due to inactivity. |