Bug 503189
| Summary: | Review Request: python-gnutls - Python wrapper for the GNUTLS library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.1.8-3.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-24 19:33:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Lemenkov
2009-05-29 14:18:40 UTC
build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1386463 missing "BuildRequires: python-setuptools-devel" as per given at build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1386463 missing "BuildRequires: python-setuptools-devel" as per given at https://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages Thanks for the comments - I fixed this issue: http://peter.fedorapeople.org/python-gnutls.spec http://peter.fedorapeople.org/python-gnutls-1.1.8-2.fc10.src.rpm koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=1386537 Koji scratch build link is for python-application package. Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1386637 + rpmlint is NOT silent for RPM. ==> See suggestion2. + source files match upstream url 599bba969380fadc719fb49a94e5efd95084637d python-gnutls-1.1.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package python-gnutls-1.1.8-2.fc12.i586 => Provides: _gnutls_init.so Requires: /usr/bin/env libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgnutls-extra.so.26 libgnutls-extra.so.26(GNUTLS_1_4) libgnutls.so.26 libgnutls.so.26(GNUTLS_1_4) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpython2.6.so.1.0 python(abi) = 2.6 rtld(GNU_HASH) + Not a GUI application Suggestions: 1) use %global instead %define 2) Add to %prep chmod 644 examples/*.py to silent rpmlint messages python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/twisted-server.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/client.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/server.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/twisted-client.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/crypto.py python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/twisted-server.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/client.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/server.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/twisted-client.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/crypto.py /usr/bin/env APPROVED. Done. http://peter.fedorapeople.org/python-gnutls.spec http://peter.fedorapeople.org/python-gnutls-1.1.8-2.fc10.src.rpm New Package CVS Request ======================= Package Name: python-gnutls Short Description: Python wrapper for the GNUTLS library Owners: peter Branches: F-10 F-11 InitialCC: CVS done. python-gnutls-1.1.8-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-gnutls-1.1.8-3.fc11 python-gnutls-1.1.8-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-gnutls-1.1.8-3.fc10 python-gnutls-1.1.8-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-gnutls'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-5891 python-gnutls-1.1.8-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-gnutls'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-5897 python-gnutls-1.1.8-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. python-gnutls-1.1.8-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: python-gnutls New Branches: EL-4 EL-5 Owners: peter CVS done. |