Bug 503526

Created attachment 346091 [details]
Patch to address issue highlighted in the bz

The patch adds JMSMessageID as a standard JMS header in PropertyExpression.java

Hello Rajith,
could you possibly specify how to test, please?
Putting NEEDINFO.

Created attachment 346350 [details]
Patch containing the fix and a test case

You can test the fix using
ant build test -Dprofile=cpp -Dtest=SelectorTest

You could also create a standalone test case based on the SelectorTest to verify against the RPMS.

The updated RPMS will be built shortly.

On qpid-trunk revision 781360 I get:

----------------------------------------------------------------------------
qpid/java$ ant build
...
BUILD FAILED
/root/qpid/java/build.xml:139: The following error occurred while executing this line:
/root/qpid/java/build.xml:54: The following error occurred while executing this line:
/root/qpid/java/common/build.xml:79: Property qpid.svnversion was circularly defined.

Total time: 1 second
----------------------------------------------------------------------------
Is that OK, Rajith? How can I fix it?

And I am not able to separate SelectorTest out of the tree.

Try adding -Dqpid.svnversion=exported to the ant command line.

My jasan.testprofile:
----------------------------
broker.version=0-10
broker=/usr/sbin/qpidd -p @PORT --data-dir ${build.data}/@PORT -t --auth no
test.excludesfile=${project.root}/ExcludeList ${project.root}/010ExcludeList
----------------------------

# ant build test -Dprofile=jasan -Dtest=SelectorTest -Dqpid.svnversion=exported

runs successfully even against qpidd-0.5.752581-5.el5 (1.1.1)
and I find it strange.

Hmm, because it uses JAR files form its trunk build.

Is there any way to force "ant test" to use exclusively JAR
files from /usr/share/jar (the RPM installed ones)?

Current status is that I will try to reproduce the bug on
  qpid-java-0.5.751061-2.el5.src.rpm (yes, source RPM)
and if it is positive, I will verify it on the latest one.

Another option is to separate SelectorTest, which I am not
able to do myself (I have tried that already).

I have verified it the above-written way using the source
RPMs. In 0.5.751061-2 I had to patch SelectorTest, but
not the PropertyExpression.java file so the test runs
as it should, but the error is still there.

For the second case I fully patched the 0.5.751061
with bz503526.patch (included in qpid-java-0.5.751061-7.el5.src.rpm)

I used following line to trigger the test in those trees:
ant build test -Dprofile=jasan -Dtest=SelectorTest -Dqpid.svnversion=exported

  * In half-patched 0.5.751061 tree
    BUILD FAILED
    ...: TEST SUITE FAILED

  * In patched 0.5.751061 tree
    BUILD SUCCESSFUL

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1097.html