Bug 503567
| Summary: | local variable clobbers global rootdev | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Bryn M. Reeves <bmr> | ||||
| Component: | mkinitrd | Assignee: | Hans de Goede <hdegoede> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Alexander Todorov <atodorov> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.3 | CC: | atodorov, borgan, cward, ddumas, hdegoede, jean.francois.lassignardie, jruemker, rprice, tao | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-03-30 08:59:40 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 499522, 531114 | ||||||
| Attachments: |
|
||||||
|
Description
Bryn M. Reeves
2009-06-01 18:29:53 UTC
I think the reason we don't always see this is here: 1250 if [ -z "$rootdevs" ]; then 1251 rootdevs="$rootdev" 1252 fi This appears right after dm device dependencies have been discovered. If we arrive here with a zero-length rootdevs then the value of rootdev at the end of the following loop is always equal to rootdev and the generated init script is correct. Otoh, if rootdevs is a list of component devices (e.g. "/dev/sdc /dev/sdf" etc.) then we get the incorrect behaviour. Created attachment 346118 [details]
rename local variable to avoid conflict with global rootdev
Patch from John Ruemker to correct rootdev aliasing.
After patch review, adding dev ack for this one. I'll take care of this one. This is fixed in mkinitrd-5.1.19.6-55 . ~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~ RHEL 5.5 Beta has been released! There should be a fix present in this release that addresses your request. Please test and report back results here, by March 3rd 2010 (2010-03-03) or sooner. Upon successful verification of this request, post your results and update the Verified field in Bugzilla with the appropriate value. If you encounter any issues while testing, please describe them and set this bug into NEED_INFO. If you encounter new defects or have additional patch(es) to request for inclusion, please clone this bug per each request and escalate through your support representative. Fix confirmed in 5.5 beta. initrd-orig contains initrd contents from a 5.4 mpath install, initrd-503567 contains initrd contents created from mkinitrd-5.1.19-6.56: # grep mkrootdev initrd-orig/init initrd-503567/init initrd-orig/init:mkrootdev -t ext3 -o defaults,ro /dev/sdc initrd-503567/init:mkrootdev -t ext3 -o defaults,ro /dev/VolGroup00/LogVol00 # rpm -q mkinitrd mkinitrd-5.1.19.6-56 -John Moving to VERIFIED as per comment #14 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2010-0295.html *** Bug 457216 has been marked as a duplicate of this bug. *** |