Bug 504087

Summary:	Review Request: perl-Catalyst-Helper-FastCGI-ExternalServer - FastCGI daemon start/stop script for using FastCgiExternalServer
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Catalyst-Helper-FastCGI-ExternalServer
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-06-04 16:29:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Weyl 2009-06-04 06:27:33 UTC

Spec URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-Helper-FastCGI-ExternalServer.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-Helper-FastCGI-ExternalServer-0.05-1.fc10.src.rpm

Description:
This module allows configuration using /etc/sysconfig/myapp. First make
a file called /etc/sysconfig/myapp and then write some variables in it.
The variables that you add to the file will automatically override the
environment variables.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1393092

*rt-0.10

Comment 1 Parag AN(पराग) 2009-06-04 06:56:01 UTC

Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1393092
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
14d8c45d1abe24bd4c66456003aafb663b1aace5  Catalyst-Helper-FastCGI-ExternalServer-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=4, Tests=6,  2 wallclock secs ( 0.05 usr  0.01 sys +  1.64 cusr  0.05 csys =  1.75 CPU)
+ Package perl-Catalyst-Helper-FastCGI-ExternalServer-0.05-1.fc12.noarch =>
Provides: perl(Catalyst::Helper::FastCGI::ExternalServer) = 0.05
Requires: perl(Catalyst::Utils) perl(Cwd) perl(DateTime) perl(File::Spec) perl(Getopt::Long) perl(strict) perl(warnings)
+ Not a GUI application

APPROVED.

Comment 2 Chris Weyl 2009-06-04 15:14:13 UTC

New Package CVS Request
=======================
Package Name: perl-Catalyst-Helper-FastCGI-ExternalServer
Short Description: FastCGI daemon start/stop script for using FastCgiExternalServer
Owners: cweyl
Branches: F-9 F-10 F-11 devel
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2009-06-04 15:36:00 UTC

CVS done.

Comment 4 Chris Weyl 2009-06-04 16:29:10 UTC

Thanks for the review! :-)