Bug 504403
Summary: | Review Request: perl-Cache-Memcached - Perl client for memcached | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael Fleming <mfleming+rpm> |
Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | emmanuel, fedora-package-review, notting |
Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-06-29 09:29:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Michael Fleming
2009-06-06 10:53:45 UTC
? Rpmlint must be run on every package. OK The package must be named according to the Package Naming Guidelines. OK The spec file name must match the base package %{name}. OK The package must meet the Packaging Guidelines. ? The package must be licensed with a Fedora approved license. OK The License field in the package spec file must match the actual license. OK If (and only if) the source package includes the text of the license(s) in its own file. OK The spec file must be written in American English. OK The spec file for the package MUST be legible. OK The sources used to build the package must match the upstream source. ff74342ce45fbb2115792b0d24d7ae8c OK The package MUST successfully compile. OK Correct BuildRequires. OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. OK Shared library files (not just symlinks) must call ldconfig in %post and %postun. OK Relocatable package must state this fact in the request for review. OK A package must own all directories that it creates. OK A package must not contain any duplicate files in the %files listing. OK Permissions on files must be set properly. OK Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK Each package must consistently use macros. OK The package must contain code, or permissable content. OK Large documentation files must go in a -doc subpackage. OK If a package includes something as %doc, it must not affect the runtime of the application. OK Header files must be in a -devel package. OK Static libraries must be in a -static package. OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so (without suffix) must go in -devel. OK In the vast majority of cases, devel packages must require the base package. OK Packages must NOT contain any .la libtool archives. OK Packages containing GUI applications must include a %{name}.desktop file. OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). Remove rf from release, because it makes rpmlint scream. Also there is problem with license. I found the same as Perl itself in Cache.pm file. Ah, this is what happens when I try and write a blog post and keep an eye on IRC / microblogs when making quick hacks to a .spec New Spec URL: http://mfleming.fedorapeople.org/perl-Cache-Memcached.spec SRPM URL: http://mfleming.fedorapeople.org/perl-Cache-Memcached-1.26-3.fc10.src.rpm [mfleming@defender mfleming]$ rpmlint /home/mfleming/rpmbuild/SRPMS/perl-Cache-Memcached-1.26-3.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [mfleming@defender mfleming]$ rpmlint perl-Cache-Memcached.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. The spec file in srpm is all right. ACCEPT New Package CVS Request ======================= Package Name: perl-Cache-Memcached Short Description: Perl client for memcached Owners: mfleming Branches: F10 F11 EL-4 EL-5 cvs done. Package Change Request ====================== Package Name: perl-Cache-Memcached New Branches: epel7 Owners: eseyman InitialCC: perl-sig Git done (by process-git-requests). |