Bug 504475
| Summary: | Review Request: rubygem-polyglot - Allow hooking of language loaders for specified extensions into require | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Michal Ingeli <mi> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mi, notting |
| Target Milestone: | --- | Flags: | mi:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-08 15:47:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 504468, 504479 | ||
|
Description
Lubomir Rintel
2009-06-07 11:44:55 UTC
Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-polyglot.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-polyglot-0.2.5-2.fc11.src.rpm * license ok * files listed twice: Processing files: rubygem-polyglot-0.2.5-2.fc10 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/polyglot-0.2.5/History.txt warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/polyglot-0.2.5/License.txt warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/polyglot-0.2.5/Manifest.txt warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/polyglot-0.2.5/README.txt warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/polyglot-0.2.5/website/index.txt SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-polyglot.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-polyglot-0.2.5-3.fc11.src.rpm * rpmlint almost quiet
- rubygem-polyglot.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/polyglot-0.2.5/log/debug.log
- empty but in gems file listing so its ok
* named well
* clean SPEC file, American English
* builds in mock
* filelists, documentation ok, tests in documentation
* provides and requires ok
should:
* run tests in %check (test/test_polyglot.rb)
Well, the Rakefile requres the gem to rebuild for the tests to run, and the only existing test is about being completely useless.
class TestPolyglot < Test::Unit::TestCase
def setup
end
def test_truth
assert true
end
end
Hmm, that test doesn't really make sense. So it's probably OK to skip it. APPROVED New Package CVS Request ======================= Package Name: rubygem-polyglot Short Description: Allow hooking of language loaders for specified extensions into require Owners: lkundrak Branches: F-10 F-11 EL-5 CVS done. Imported and built. Thanks for the review! |