Bug 504478

Summary:	Review Request: rubygem-diff-lcs - Provide a list of changes between two sequenced collections
Product:	[Fedora] Fedora	Reporter:	Lubomir Rintel <lkundrak>
Component:	Package Review	Assignee:	Michal Ingeli <mi>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, mi, notting, tdawson
Target Milestone:	---	Flags:	mi: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-07-08 18:05:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lubomir Rintel 2009-06-07 11:45:11 UTC

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-diff-lcs.spec
SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-diff-lcs-1.1.2-1.fc11.src.rpm

Description:

Diff::LCS is a port of Algorithm::Diff that uses the McIlroy-Hunt longest
common subsequence (LCS) algorithm to compute intelligent differences between
two sequenced enumerable containers. The implementation is based on Mario I.
Wolczko's Smalltalk version (1.2, 1993) and Ned Konz's Perl version
(Algorithm::Diff).

Comment 1 Lubomir Rintel 2009-06-07 11:58:53 UTC

rubygem-diff-lcs.noarch: W: invalid-license Artistic

This actual license is "GPLv2+ or Ruby or Artistic" which is indeed valid. I suspect rpmlint only recognizes "Artistic" in "GPL+ or Artistic" a.k.a. "Perl license".

Comment 2 Lubomir Rintel 2009-06-08 11:44:45 UTC

Attempted to incorporate comments from here:
https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-diff-lcs.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-diff-lcs-1.1.2-2.fc11.src.rpm

Comment 3 Lubomir Rintel 2009-06-27 06:30:11 UTC

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-diff-lcs.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-diff-lcs-1.1.2-3.fc11.src.rpm

Comment 4 Michal Ingeli 2009-07-01 13:49:29 UTC

* naming OK
* licensing OK
* Clean, legible spec file, American English
* source file matches upstream
* file list, documentation, permissions OK
* builds in mock
* rpmlint warnd about Artistic license, but upstream also declares usage of Ruby and GPLv2+, and that's OK

APPROVED

Comment 5 Lubomir Rintel 2009-07-08 15:48:45 UTC

New Package CVS Request
=======================
Package Name: rubygem-diff-lcs
Short Description: Provide a list of changes between two sequenced collections
Owners: lkundrak
Branches: F-10 F-11 EL-5

Comment 6 Jason Tibbitts 2009-07-08 16:34:25 UTC

CVS done.

Comment 7 Lubomir Rintel 2009-07-08 18:05:06 UTC

Imported and built.
Thanks for review and CVS!

Comment 8 Troy Dawson 2014-07-18 21:55:12 UTC

Package Change Request
======================
Package Name: rubygem-diff-lcs
New Branches: epel7
Owners: tdawson

Comment 9 Gwyn Ciesla 2014-07-21 12:38:09 UTC

Git done (by process-git-requests).