Bug 504479

rubygem-cucumber.noarch: W: wrong-file-end-of-line-encoding /usr/lib/ruby/gems/1.8/doc/cucumber-0.3.10/examples/dos_line_endings/features/dos_line_endings.feature

This file demonstrates CRLF handling, therefore is ok to have CRLF line endings.

rubygem-cucumber.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/cucumber-0.3.10/rails_generators/cucumber/templates/cucumber 0644

This is ok as well -- it is a script template, has a shebang but should not be executable.

Attempted to incorporate comments from here:
https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-cucumber.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-cucumber-0.3.10-2.fc11.src.rpm

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-cucumber.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-cucumber-0.3.10-3.fc11.src.rpm

Lubomir, if it is possible, could you please package latest version? (0.3.93.1)

ping?

Hi, I'm working on ruby packages that could benefit from this, willing to help.

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-cucumber.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-cucumber-0.4.0-1.fc11.src.rpm

Matthew: Feel free to step in whenever a packager is irresponsive (such as me).

1] rpmlint complaining:
1a]
rubygem-cucumber.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/cucumber-0.4.0/rails_generators/cucumber/templates/cucumber 0644 /usr/bin/env
template, it should be ok to leave it like it is.

1b]
rubygem-cucumber.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Ast/Table/diff%21-i.yaml %21
rubygem-cucumber.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Parser/Feature/Background1/matches_tags%3f-i.yaml %3f
rubygem-cucumber.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Parser/Feature/ScenarioOutline1/matches_name%3f-i.yaml %3f
rubygem-cucumber.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Cli/ProfileLoader/cucumber_yml_defined%3f-i.yaml %3f
rubygem-cucumber.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Parser/Feature/ScenarioOutline1/outline_matches_name%3f-i.yaml %3f

There is lot of warnings (50) misspelled-macro (%3f in name of file), what is reason for this characters in filename?

(In reply to comment #8)
> 1] rpmlint complaining:
> 1a]
> rubygem-cucumber.noarch: E: non-executable-script
> /usr/lib/ruby/gems/1.8/gems/cucumber-0.4.0/rails_generators/cucumber/templates/cucumber
> 0644 /usr/bin/env
> template, it should be ok to leave it like it is.

Yep.

> 1b]
> rubygem-cucumber.noarch: W: misspelled-macro
> /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Ast/Table/diff%21-i.yaml
> %21
> rubygem-cucumber.noarch: W: misspelled-macro
> /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Parser/Feature/Background1/matches_tags%3f-i.yaml
> %3f
> rubygem-cucumber.noarch: W: misspelled-macro
> /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Parser/Feature/ScenarioOutline1/matches_name%3f-i.yaml
> %3f
> rubygem-cucumber.noarch: W: misspelled-macro
> /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Cli/ProfileLoader/cucumber_yml_defined%3f-i.yaml
> %3f
> rubygem-cucumber.noarch: W: misspelled-macro
> /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Parser/Feature/ScenarioOutline1/outline_matches_name%3f-i.yaml
> %3f
> 
> There is lot of warnings (50) misspelled-macro (%3f in name of file), what is
> reason for this characters in filename?  

Upstream.

(In reply to comment #9)
> (In reply to comment #8)
> > 1b]
> > rubygem-cucumber.noarch: W: misspelled-macro
> > /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Ast/Table/diff%21-i.yaml
> > %21
> > rubygem-cucumber.noarch: W: misspelled-macro
> > /usr/lib/ruby/gems/1.8/doc/cucumber-0.4.0/ri/Cucumber/Parser/Feature/Background1/matches_tags%3f-i.yaml
> > %3f
>
> Upstream.  

These are ri document files generated by rdoc (something like
doxygen-generated html files or man files)

For example, Cucumber/Ast/Table/diff%21-i.yaml corresponds to the
following command:
$ ri Cucumber::Ast::Table#diff!
Note the end "!", on the file name of ri yaml file this is escaped.
This shows the explanation of Cucumber::Ast::Table#diff! .
And Cucumber/Parser/Feature/Background1/matches_tags%3f-i.yaml corresponds
to
$ ri Cucumber::Parser::Feature::Background1#matches_tags?

Note that F-11/12/13 ri command cannot detect ri files installed
by Gems (based Fedora rpm) (not checked F-10 package)
and you may want to try new "ruby" rpm:
http://koji.fedoraproject.org/koji/buildinfo?buildID=136502
http://koji.fedoraproject.org/koji/buildinfo?buildID=136503
http://koji.fedoraproject.org/koji/buildinfo?buildID=136509

By the way 4.2 is released.

- license ok
- rpmlint complaining, however it could be safely ignored
- location correct
- macros usage correct
- md5sum of source correct
- build ok
- guidelines ok
- ruby specific guidelines ok
- naming ok

as new version (0.4.2) was released, please update package to this version, hope following diff between yours and mine spec file will help.

--- SPECS/rubygem-cucumber.spec.old	2009-10-15 22:16:05.912579939 +0200
+++ SPECS/rubygem-cucumber.spec	2009-10-15 22:29:50.804448521 +0200
@@ -47,6 +47,11 @@
 
 # Remove zero-length documentation files
 find $RPM_BUILD_ROOT%{gemdir}/doc/%{gemname}-%{version} -empty -delete
# Manifest.txt is now zero-lenght
+rm $RPM_BUILD_ROOT%{geminstdir}/Manifest.txt
+
+# remove non-needed git repo files
+rm $RPM_BUILD_ROOT%{geminstdir}/.gitattributes
+find $RPM_BUILD_ROOT%{geminstdir} -name ".gitignore" -delete
 
 
 %clean
@@ -58,20 +63,19 @@
 %{_bindir}/cucumber
 %dir %{geminstdir}
 %{geminstdir}/bin
-%{geminstdir}/config
 %{geminstdir}/features
 %{geminstdir}/gem_tasks
 %{geminstdir}/lib
 %{geminstdir}/rails_generators
 %{geminstdir}/spec
-%{geminstdir}/cucumber.yml
+%{geminstdir}/cucumber.*
 %{geminstdir}/Rakefile
+%{geminstdir}/VERSION.yml
 %doc %{geminstdir}/examples
 %doc %{gemdir}/doc/%{gemname}-%{version}
 %doc %{geminstdir}/History.txt
-%doc %{geminstdir}/License.txt
-%doc %{geminstdir}/Manifest.txt
-%doc %{geminstdir}/README.txt
+%doc %{geminstdir}/LICENSE
+%doc %{geminstdir}/README.rdoc
 %{gemdir}/cache/%{gemname}-%{version}.gem
 %{gemdir}/specifications/%{gemname}-%{version}.gemspec


conclusion: approved when package updated to 0.4.2

Thanks, will apply upon import.

New Package CVS Request
=======================
Package Name: rubygem-cucumber
Short Description: Tool to execute plain-text documents as functional tests
Owners: lkundrak mkent
Branches: F-11 F-12 EL-5

cvs done.

builded and pushed into updates

*** Bug 588431 has been marked as a duplicate of this bug. ***

Package Change Request
======================
Package Name: rubygem-cucumber
New Branches: epel7
Owners: tdawson

Git done (by process-git-requests).