Bug 504735

Summary: reflect IME toolbar UI in systray applet menu
Product: [Fedora] Fedora Reporter: Jens Petersen <petersen>
Component: ibusAssignee: fujiwara <tfujiwar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: i18n-bugs, phuang, tfujiwar
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-02-18 15:27:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for ibus setup.ui, languagebar.py
none
Patch for ibus setup.ui, languagebar.py, panel.py
none
Patch for ibus setup.ui, languagebar.py, panel.py
none
Patch for ibus setup.ui, languagebar.py, panel.py none

Description Jens Petersen 2009-06-09 03:15:30 UTC
Description of problem:
For users with the toolbar disabled it would be nice to be able to access/see the toolbar UI through the systray menu if possible.

Comment 1 Bug Zapper 2009-06-09 17:14:17 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Jens Petersen 2009-07-14 23:26:33 UTC
moving back to rawhide

Comment 3 Bug Zapper 2009-11-16 10:02:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 fujiwara 2010-01-04 09:29:16 UTC
Created attachment 381510 [details]
Patch for ibus setup.ui, languagebar.py

This is a first idea for the embedded languagebar.

Comment 5 Peng Huang 2010-01-08 05:34:20 UTC
I tested it. It looks OK in gnome, but it does not work in KDE 4.3.90.

Comment 6 fujiwara 2010-01-08 08:42:16 UTC
(In reply to comment #5)
> I tested it. It looks OK in gnome, but it does not work in KDE 4.3.90.  

Thanks for your review.


I thought embedded languagebar is nice but in fact the bug reporter means to show the contents of languagebar in menu of ibus status icon on panel systray.

I'll revise the patch next week.

Comment 7 fujiwara 2010-01-18 10:13:23 UTC
Created attachment 385040 [details]
Patch for ibus setup.ui, languagebar.py, panel.py

Revised the patch to show languagebar menus in status icon menu.

Comment 8 fujiwara 2010-01-19 05:14:14 UTC
Created attachment 385313 [details]
Patch for ibus setup.ui, languagebar.py, panel.py

Revised for RadioMenuItem() typo and the implementation of update_property().

Comment 9 fujiwara 2010-01-19 06:51:18 UTC
Created attachment 385323 [details]
Patch for ibus setup.ui, languagebar.py, panel.py

Revised the patch:
 - Fixed "About - %s"
 - Fixed import SeparatorMenuItem

Comment 10 Peng Huang 2010-01-19 08:13:23 UTC
(In reply to comment #9)
> Created an attachment (id=385323) [details]
> Patch for ibus setup.ui, languagebar.py, panel.py
> 
> Revised the patch:
>  - Fixed "About - %s"
>  - Fixed import SeparatorMenuItem

Applied this patch in upstream. And I will built it soon.

Comment 11 fujiwara 2010-01-19 10:31:08 UTC
Thanks for the integration.
Just now I think the bottom panel appearance, which is the default in KDE.
http://fujiwara.fedorapeople.org/ibus/20100119/ibus-504735-bottom-menu.diff

Comment 12 Peng Huang 2010-01-25 08:34:51 UTC
(In reply to comment #11)
> Thanks for the integration.
> Just now I think the bottom panel appearance, which is the default in KDE.
> http://fujiwara.fedorapeople.org/ibus/20100119/ibus-504735-bottom-menu.diff    

I think it is not necessary.

Comment 13 fujiwara 2010-01-26 03:39:58 UTC
The previous patch included a bug fix so I removed the bottom menu item feature.

The commit includes the bug fix only:
http://github.com/fujiwarat/ibus/commit/59b2900f7336082b5690db4195e939b99a009a1f

Comment 14 Peng Huang 2010-02-18 15:27:18 UTC
Built it for rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=154049