Bug 504795
| Summary: | htop aborts after hitting F6 key | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Nowak <mnowak> | ||||
| Component: | htop | Assignee: | Rafał Psota <rafalzaq> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | dmach, fedora-bugs, ohudlick, rafalzaq | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.8.2-2.fc11 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-06-16 01:20:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Michal Nowak
2009-06-09 13:52:33 UTC
I hit the same problem on pressing '>' key which also opens sort menu. Strace shows that htop ends with SIGSEGV (Segmentation fault) just after pressing the key. Program received signal SIGSEGV, Segmentation fault. strlen () at ../sysdeps/i386/i486/strlen.S:40 40 cmpb %ch, (%eax) /* is byte NUL? */ Current language: auto; currently asm (gdb) bt all No symbol "all" in current context. (gdb) bt #0 strlen () at ../sysdeps/i386/i486/strlen.S:40 #1 0x00a5f0e5 in __strdup (s=0x4a2ed0aa <Address 0x4a2ed0aa out of bounds>) at strdup.c:42 #2 0x0804cc51 in FunctionBar_new (functions=0xbfa8f780, keys=0xbfa8d9fc, events=0xbfa8d9f4) at FunctionBar.c:57 #3 0x0804d7cb in pickFromVector (panel=0x8513880, list=0x851f180, x=15, y=5, keyLabels=0xbfa8f780, prevBar=0x8513ef8) at htop.c:198 #4 0x0804ff33 in main (argc=1, argv=Cannot access memory at address 0x6 ) at htop.c:707 yeah, I hit this in bug 505387. The problem is, that we don't know the size of the functions array. http://htop.svn.sourceforge.net/viewvc/htop/trunk/FunctionBar.c?revision=155&view=markup has a dumb logic in line 55 iterating blindly over 15 elements, even if the array has two elements only. I cooked up patch 347448 which might fix your issue as well. patch #347448 doesn't fix this issue, but patch #347449 does :) Happy Patching! Created attachment 347524 [details] Patch from bug 505387 *** Bug 505387 has been marked as a duplicate of this bug. *** I tested the patch by Tobias and it fixes both "a" and "F6" bugs. Can you please post it upstream? I've also noticed small typos here:
#remove empty direcories
rm -rf $RPM_BUILD_ROOT%{prefix}/lib
rm -rf $RPM_BUILD_ROOT%{prefix}/include
should be something like this:
#remove empty directories
rmdir $RPM_BUILD_ROOT%{_libdir}
rmdir $RPM_BUILD_ROOT%{_includedir}
Wow. A few days of absence, and I have another bug fixed. Thanks! htop-0.8.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/htop-0.8.2-2.fc10 htop-0.8.2-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/htop-0.8.2-2.fc9 htop-0.8.2-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/htop-0.8.2-2.fc11 htop-0.8.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. htop-0.8.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. htop-0.8.2-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |