Bug 505009

Summary: cobbler-1.6.5-1.fc10 does not accept --os-version=Fedora11
Product: [Fedora] Fedora Reporter: Egon Kastelijn <redhat2>
Component: cobblerAssignee: Michael DeHaan <mdehaan>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 10CC: mdehaan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-10 13:15:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for /usr/lib/python2.5/site-packages/cobbler/codes.py.orig (diff -u)
none
/usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py patch (diff -u) none

Description Egon Kastelijn 2009-06-10 11:12:09 UTC 
Created attachment 347199 [details]
Patch for /usr/lib/python2.5/site-packages/cobbler/codes.py.orig (diff -u)

Description of problem:
cobbler-1.6.5-1.fc10 does not accept --os-version=Fedora11

Version-Release number of selected component (if applicable):
cobbler-1.6.5-1.fc10

How reproducible:
Always

Steps to Reproduce:
1. Download Fedora11 on a Fedora10 machine
2. mount -o loop Fedora-11-i386-DVD.iso /var/www/install/linux/fedora/11/x86_64/base
3. cobbler import --path=/var/www/install/linux/fedora/11/x86_64/base --name=Fedora11_x86_64 --available-as=http://install.kastelijn.nu/linux/fedora/11/x86_64/base
(cobbler does not recognize the os-version at this point)
4. cobbler distro edit --name=Fedora11-x86_64 --os-version=fedora11

Actual results:
--os-version for breed redhat must be one of rhel2.1, rhel3, rhel4, rhel5, fedora5, fedora6, fedora7, fedora8, fedora9, fedora10, generic24, generic26, other, given was fedora11

Expected results:
Cobbler 'should' accept fedora11 as a valid os-version

Additional info:
The os-versions are stored in this file:
/usr/lib/python2.5/site-packages/cobbler/codes.py
An extra option is needed on line 44: "fedora11",
Comment 1 Egon Kastelijn 2009-06-10 12:45:01 UTC 
Created attachment 347214 [details]
/usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py patch (diff -u)

Patch for /usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py
Comment 2 Egon Kastelijn 2009-06-10 12:45:49 UTC 
I saw that python-virtinst also needs an extra entry for fedora11.
(see attachment for a patch)
Comment 3 Michael DeHaan 2009-06-10 13:15:27 UTC 
Thanks, although you will need to send patches for virtinst if any to et-mgmt-tools

Cobbler already has this fixed on both branches:

http://git.fedorahosted.org/git/cobbler?p=cobbler;a=commitdiff;h=7f1e4795ffa91ddf9d5c097248cf9e58eace5f6c

Though we haven't announced it, there is an src RPM containing this here:

http://mdehaan.fedorapeople.org/files/cobbler/testing/

It will also be fixed in the 2.0 release should we not decide to release another 1.6.X to Fedora/EPEL.