Bug 505329

Summary:	libguestfs 'make check' should never hang
Product:	[Community] Virtualization Tools	Reporter:	Richard W.M. Jones <rjones>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	unspecified	CC:	virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-05-12 12:15:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2009-06-11 14:17:32 UTC

If 'make check' fails, it sometimes hangs (because the
underlying qemu process also hangs under many different
circumstances).

Instead, 'make check' should fail after a suitable timeout.

Possibly a simple way to implement this would be to add
alarm (LARGE_NUMBER) to tests.c.  'tests.c' is the first
test which runs, and so is the one which is likely to
hang.

Comment 1 Richard W.M. Jones 2009-06-11 16:02:00 UTC

Should be fixed by:
http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=6a623e37e191385c0d9285e3ec1136b2a02e6156

Comment 2 Fedora Update System 2009-06-23 09:15:06 UTC

libguestfs-1.0.51-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libguestfs-1.0.51-1.fc11

Comment 3 Fedora Update System 2009-06-29 19:27:46 UTC

libguestfs-1.0.54-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libguestfs-1.0.54-2.fc11

Comment 4 Fedora Update System 2009-07-02 23:26:33 UTC

libguestfs-1.0.55-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libguestfs-1.0.55-1.fc11

Comment 5 Fedora Update System 2009-07-11 09:27:31 UTC

libguestfs-1.0.58-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libguestfs-1.0.58-2.fc11

Comment 6 Fedora Update System 2009-07-11 17:12:53 UTC

libguestfs-1.0.54-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2009-07-19 10:28:09 UTC

libguestfs-1.0.58-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Richard W.M. Jones 2010-03-27 10:24:56 UTC

I'm embarrassed to say that this bug has reappeared
because of code movements that we've made.

Comment 9 Richard W.M. Jones 2010-03-27 10:50:53 UTC

Fixed (again) upstream here:

http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=ef3a6692412b234a46326d330943556977f7c988

Comment 10 Fedora Update System 2010-04-09 14:10:22 UTC

libguestfs-1.2.1-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libguestfs-1.2.1-1.fc13

Comment 11 Fedora Update System 2010-04-13 07:43:55 UTC

libguestfs-1.2.2-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libguestfs-1.2.2-1.fc13

Comment 12 Fedora Update System 2010-04-30 23:47:04 UTC

libguestfs-1.2.2-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.