Bug 505354

Please note that the original (public domain) tarball includes a font with an incompatible license: the package removes this font, requires the dejavu fonts and uses those as a default replacement.

New version: http://monnerat.fedorapeople.org/php-captchaphp-2.0-2.fc10.src.rpm
* Tue Jun 23 2009 Patrick Monnerat <pm> 2.0-2
- Move class files to a package-specific sub-directory.
- Get rid of build dependence on "ed".

rpmlint output: none
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1458801

This does build, but the resulting package does not install.  My build script catches this because it installs the built packages into the chroot.

Executing command: /usr/bin/yum --installroot /mock/fedora-rawhide-x86_64/root/  install /mock/fedora-rawhide-x86_64/result/php-captchaphp-2.0-2.fc12.noarch.rpm                                                             

php-captchaphp-2.0-2.fc12.noarch from /php-captchaphp-2.0-2.fc12.noarch has depsolving problems                                           
  --> Missing Dependency: dejavu-fonts is needed by package php-captchaphp-2.0-2.fc12.noarch (/php-captchaphp-2.0-2.fc12.noarch)          
Error: Missing Dependency: dejavu-fonts is needed by package php-captchaphp-2.0-2.fc12.noarch (/php-captchaphp-2.0-2.fc12.noarch)

Thanks Jason for catching it! I run it on F10, so it was still OK.
New SRPM: http://monnerat.fedorapeople.org/php-captchaphp-2.0-3.fc10.src.rpm
This new version requires the font directory rather than the font package: this should work identically for F10, F11 and rawhide.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1471220

New SRPM: http://monnerat.fedorapeople.org/php-captchaphp-2.0-4.fc10.src.rpm
PHP requirements minimized.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1576229
Rpmlint silent.

New version:
http://monnerat.fedorapeople.org/php-captchaphp.spec
http://monnerat.fedorapeople.org/php-captchaphp-2.2-1.fc12.src.rpm

New upstream release.
Font file with bad license removed from source tarball.
Some spelling errors fixed in description.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2208427

Rpmlint output:
php-captchaphp.spec: W: invalid-url Source0: captcha-2.2.nofont.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
SRPMS/php-captchaphp-2.2-1.fc12.src.rpm 
php-captchaphp.src: W: invalid-url Source0: captcha-2.2.nofont.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
RPMS/noarch/php-captchaphp-2.2-1.fc12.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Warnings due to custom source tarball (see comment in spec file).

Since this package is
_ stalled for almost one year without any potential reviewer,
_ a dependence blocking WebCalendar that has already passed the review (and has a new upstream version since then),
_ very simple and easy to review,
I would be very grateful to the reviewer who will be interested in this package and finally unblock the situation. Thanks in advance.

Review
=======
- rpmlint checks return:
php-captchaphp.src:6: W: macro-in-comment %{version}
php-captchaphp.src:7: W: macro-in-comment %{version}
php-captchaphp.src:8: W: macro-in-comment %{version}
php-captchaphp.src:9: W: macro-in-comment %{version}
php-captchaphp.src:9: W: macro-in-comment %{version}
php-captchaphp.src: W: invalid-url Source0: captcha-2.2.nofont.tar.gz

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on F-13 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

One minor change:

Since Public Domain declarations are problematic (we don't know if the copyright holder is able to legally put this work into the public domain), and the copyright holder has given permission for it to be used under any FOSS license, please adjust the licensing in the spec to this:

# Public Domain or any FOSS License, see README
# We're choosing MIT because it is universally compatible with other FOSS 
# licenses.
License: Public Domain or MIT

Make that change and I will approve this.

I thank you very much for the review, Spot: as ever, you are my savior :-)

> License: Public Domain or MIT

Change applied:
http://monnerat.fedorapeople.org/php-captchaphp.spec
http://monnerat.fedorapeople.org/php-captchaphp-2.2-2.fc12.src.rpm

Approved, sorry for the delay, was on vacation.

No problem: I'm myself on vacation this week !
Many thanks for your review, Spot.

New Package CVS Request
=======================
Package Name: php-captchaphp
Short Description: PHP very user-friendly CAPTCHA
Owners: monnerat
Branches: F-12 F-13
InitialCC:

CVS done (by process-cvs-requests.py).

php-captchaphp-2.2-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/php-captchaphp-2.2-2.fc13

php-captchaphp-2.2-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/php-captchaphp-2.2-2.fc12

Thanks for CVS Kevin. Package now uploaded and built in devel F-12 and F-13 branches.

php-captchaphp-2.2-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

php-captchaphp-2.2-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.