Bug 50542

Summary: errors in error messages
Product: [Retired] Red Hat Linux Reporter: Michal Jaegermann <michal>
Component: gdmAssignee: Havoc Pennington <hp>
Status: CLOSED WONTFIX QA Contact: Aaron Brown <abrown>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-08-01 13:06:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch for printf argument problems in gdm-2.2.3.1 none

Description Michal Jaegermann 2001-08-01 00:39:25 UTC 
Description of Problem:

A recompilation of gdm from 'roswell' generates pretty well deserved
compiler complaints.  I believe that attached patch is needed but
it should be reviewed by somebody more familiar with internals.

As an aside - replacing in gui/gdmlogin.c this:
       gnome_dialog_grab_focus (GNOME_DIALOG (dialog), 0);
with
       gtk_widget_grab_focus (GTK_WINDOW (dialog));
allows to compile this source with older libraries (like those included
in 7.1).  Not sure if entirely correct but so far it works just fine. :-)
Maybe 'configure' could do that by itself?

  Michal
  michal
Comment 1 Michal Jaegermann 2001-08-01 00:41:17 UTC 
Created attachment 25691 [details]
patch for printf argument problems in gdm-2.2.3.1
Comment 2 Havoc Pennington 2001-08-01 14:10:36 UTC 
I believe gnome_dialog_grab_focus() grabs focus on the 0th button of the dialog,
not the dialog itself as with gtk_widget_grab_focus(). Grumble, this function
should NOT have been added to libgnomeui for exactly the reason you mention - it
looks like someone (I know who) snuck it in without a ChangeLog entry.

Patch looks great though. I am moving this bug upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=58393
and closing it here.