Bug 505420

Summary: pkgorder misses some kernel packages
Product: [Fedora] Fedora Reporter: Dennis Gregorovic <dgregor>
Component: pungiAssignee: David Cantrell <dcantrell>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 11CC: dcantrell
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-22 20:11:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dennis Gregorovic 2009-06-11 20:36:58 UTC
Description of problem:
In pkgorder:

    # hack, hack, hack... make sure iscsi ends up on disc1 (#208832)                                                                                  
    addPackages(ds, ["kernel-*","mkinitrd","mdadm"])
...
    #Everthing else but kernels                                                                                                                       
    for po in ds.pkgSack.returnPackages():
        if po.name.find("kernel") == -1:
            member = ds.tsInfo.addInstall(po)

Because the two fragments of code search on different criteria, it's possible for packages to not get picked up by pkgorder.  In particular, the kerneloops package is missed.

Version-Release number of selected component (if applicable):
pungi-2.0.16-1.fc11

How reproducible:
always

Steps to Reproduce:
1./usr/bin/pkgorder on a tree with the kerneloops package
2.
3.
  
Actual results:
kerneloops not included in output

Expected results:
kerneloops included in output

Additional info:

Comment 1 Jesse Keating 2009-06-12 18:46:51 UTC
Hrm, good catch.  Should just change that second search to kernel- instead of kernel.

Comment 2 Jesse Keating 2009-12-22 20:11:11 UTC
Fixed upstream.