| Summary: | Review Request: acheck - Check common localisation mistakes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rakesh Pandit <rpandit> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
tibbs: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.5.1-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-21 13:11:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 505508 | ||
| Bug Blocks: | |||
|
Description
Rakesh Pandit
2009-06-12 06:58:48 UTC
Will need acheck-rules .. which I am packaging in some time. http://ftp.de.debian.org/debian/pool/main/a/acheck-rules/acheck-rules_0.3.1.tar.gz Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1424380 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 45651d7d33f69bbc2a19d674fd6a4f66302f2629 acheck_0.5.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package acheck-0.5.1-1.fc12.noarch => Provides: perl(ACheck::Common) perl(ACheck::FileType) perl(ACheck::Parser) Requires: /usr/bin/perl perl(ACheck::Common) perl(ACheck::FileType) perl(ACheck::Parser) perl(Config::General) perl(Data::Dumper) perl(Exporter) perl(File::Copy) perl(File::Spec::Functions) perl(Getopt::Long) perl(IO::File) perl(Term::ANSIColor) perl(Term::ReadLine) perl(Term::Size) perl(constant) perl(locale) perl(strict) perl(vars) + Not a GUI application Should: 1)Requires should be written as only Requires: perl(Text::Aspell), perl-gettext, %{name}-rules APPROVED. Thanks, will fix before importing New Package CVS Request ======================= Package Name: acheck Short Description: Check common localisation mistakes Owners: rakesh Branches: F-10 F-11 InitialCC: CVS done. acheck-0.5.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/acheck-0.5.1-2.fc10 acheck-0.5.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/acheck-0.5.1-2.fc11 acheck-0.5.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. acheck-0.5.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |