Bug 505508
| Summary: | Review Request: acheck-rules - Rules for acheck | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rakesh Pandit <rpandit> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3.1-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-17 05:35:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 505507 | ||
|
Description
Rakesh Pandit
2009-06-12 07:28:17 UTC
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1414186 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4f794aa188c04abf5b7ec8bb20689a689371d8e1 acheck-rules_0.3.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. Should: 1) Source URL should be Source0: http://ftp.de.debian.org/debian/pool/main/a/acheck-rules/%{name}_%{version}.tar.gz 2) also I think you should remove following Requires: acheck Fixed: http://rakesh.fedorapeople.org/spec/acheck-rules.spec http://rakesh.fedorapeople.org/srpm/acheck-rules-0.3.1-2.fc11.src.rpm New Package CVS Request ======================= Package Name: acheck-rules Short Description: Rules for acheck Owners: rakesh Branches: F-9 F-10 F-11 InitialCC: F-9 branches are no longer permitted. Otherwise, CVS is done. acheck-rules-0.3.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/acheck-rules-0.3.1-2.fc11 acheck-rules-0.3.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/acheck-rules-0.3.1-2.fc10 acheck-rules-0.3.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. acheck-rules-0.3.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |