Bug 505623
| Summary: | Review Request: python-urllib2_kerberos - Kerberos over HTTP Negotiate/SPNEGO support for urllib2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mcepl, notting, panemade, tdabasin |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-19 11:52:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matěj Cepl
2009-06-12 15:55:51 UTC
Build failed at http://koji.fedoraproject.org/koji/taskinfo?taskID=1414339 Add BuildRequires: python-setuptools-devel New version http://mcepl.fedorapeople.org/rpms/python-urllib2_kerberos.spec http://mcepl.fedorapeople.org/rpms/python-urllib2_kerberos-0.1.6-2.fc11.src.rpm and built in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1419943 Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1419943 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e77324778be206a57478eb2ef386a879c8a2e2ff urllib2_kerberos-0.1.6.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Should: 1) I don't think forcefully keeping timestamp of upstream file in which you already deleted one line is a good idea. I will suggest you only use sed -i -e "s|#!/usr/bin/env python||" urllib2_kerberos.py and let new timestamp be installed. APPROVED. (In reply to comment #3) > Should: > 1) I don't think forcefully keeping timestamp of upstream file in which you > already deleted one line is a good idea. > I will suggest you only use > sed -i -e "s|#!/usr/bin/env python||" urllib2_kerberos.py > > and let new timestamp be installed. You are right, of course. > APPROVED. Thanks a lot. New Package CVS Request ======================= Package Name: python-urllib2_kerberos Short Description: Kerberos over HTTP Negotiate/SPNEGO support for urllib2 Owners: mcepl Branches: F-10 F-11 EL-5 InitialCC: CVS done. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-3.fc10 https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-3.fc11 http://koji.fedoraproject.org/koji/packageinfo?packageID=8658 python-urllib2_kerberos-0.1.6-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-urllib2_kerberos-0.1.6-4.el6 python-urllib2_kerberos-0.1.6-4.el6 has been pushed to the Fedora EPEL 6 stable repository. |