Bug 505928

Hi Thomasz,
 
I am not able to sponsor you but I can hopefully offer some comments.

There are some rpmlint errors:

$ rpmlint ../RPMS/x86_64/hdapsd-20090401-1.fc11.x86_64.rpm 
hdapsd.x86_64: W: non-conffile-in-etc /etc/event.d/hdapsd
hdapsd.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/99-hdapsd.rules
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

which to me look like they could and should be fixed.

Maybe add a
%doc README AUTHORS ChangeLog ....

these files never do any harm to be included.
 Steve.

I've uploaded -2 version:
Spec URL: https://pipebreaker.pl/~zdzichu/pkgs/hdapsd.spec
SRPM URL: https://pipebreaker.pl/~zdzichu/pkgs/hdapsd-20090401-2.fc11.src.rpm

which marks upstart & udev files as config files. I've left other as non-marked as doc, because %doc causes them to be installed two times.

Thank you for your comments Steve!

Hi,
I think the README will have to marked as %doc somehow and not end
up in /usr/share/doc/hdapsd/

I would rm the 

$RPM_BUILD_ROOT/usr/share/doc/hdapsd/README 

file after it was created by the make install and then 
add the README direct from the source tree with

%doc README.

rpmlint works fine.

Something else to do whilst waiting for a package reviewer submit it
as a scratch build to to koji.
Start by getting an account and proceed onto Koji.
http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account
  Steve

spec/srpm seems 404...

Spec and SRPM seem to be back now.

Scratch build completed as http://koji.fedoraproject.org/koji/taskinfo?taskID=1473549 . I'm still thinking about those README, ChangeLog files. They are normally installed into /usr/share/doc/hdapsd. Marking them %doc caused *additional* installation into /usr/share/doc/hdapsd-20090401.

Well, for -2:

* SourceURL
  - For sourceforge.net hosted URL, follow:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

* $RPM_BUILD_ROOTvs %buildroot
  - Please choose one and don't use both.

* Installing %SOURCE{1,2,3}
---------------------------------------------------
cp %SOURCE1 .
...
...
cp -p hdapsd.event %{buildroot}%{_sysconfdir}/event.d/hdapsd
---------------------------------------------------
  - This can simply be:
---------------------------------------------------
cp -p %SOURCE1 %{buildroot}%{_sysconfdir}/event.d/hdapsd
---------------------------------------------------

* Document installation path
  - By default Fedora installs document files under
   %{_defaultdocdir}/%{name}-%{version}. I suggest to once
   remove all files under %{_defaultdocdir}/%{name} and
   use %doc as:
---------------------------------------------------
%install
rm -rf %{buildroot}
....
make install DESTDIR=%{buildroot}

....
rm -rf %{buildroot}%{_defaultdocdir}/%{name}
....
....
%files
%doc AUTHORS
%doc COPYING
%doc ChangeLog
%doc README
....
--------------------------------------------------
  ! By the way installing "COPYING" file is rather mandatory
    if it exists.

Mamoru,

thank you for your input. I've incorporated changes into:

Spec URL: http://pipebreaker.pl/~zdzichu/pkgs/hdapsd.spec
SRPM URL: http://pipebreaker.pl/~zdzichu/pkgs/hdapsd-20090401-3.fc11.src.rpm
Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=1490583

Well, for -3:

* SourceURL
  - Using %{version} macro in Source0 is preferred as with it
    you probably won't have to change Source0 when the version
    is upgraded:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* Installing %SOURCE{1,2,3}
---------------------------------------------------------
cp %SOURCE1 .
cp %SOURCE2 .
cp %SOURCE3 .
---------------------------------------------------------
  - I think now these lines are not needed.

And now:

-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on my wiki page:
http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets
(Check "No one is reviewing")

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines

ping?

I'm still here, sorry for delay. Combination of holiday season and some of work issues made me slacking lately. I haven't pre-reviewied any requests yet, but I'm going to. I'm still interested in becoming part of Fedora.

ping again?

My comments for my first unofficial review are at
https://bugzilla.redhat.com/show_bug.cgi?id=518799#c4

Well, okay.

------------------------------------------------------
  This package (hdaspd) is APPROVED by mtasaka
------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Install the Client Tools (Koji)".

Now I am sponsoring you.

If you want to import this package into Fedora 10/11, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Removing NEEDSPONSOR.

New Package CVS Request
=======================
Package Name: hdapsd
Short Description: Protects hard drives by parking head when fall is detected
Owners: ttorcz
Branches: F-12
InitialCC: ttorcz

cvs done.

Please rebuild this package on bodhi.

Uh, I've got problem. I did all the steps from wiki/PackageMaintainers/Join, but "make update" fails:

% make update
Creating a new update for  hdapsd-20090401-4.fc12 
Password for ttorcz: 
Creating a new update for  hdapsd-20090401-4.fc12 
hdapsd-20090401-4.fc12 not tagged as an update candidate

Yet it seems that tag already exists:
% make tag
cvs tag  -c hdapsd-20090401-4_fc12

ERROR: Tag hdapsd-20090401-4_fc12 has been already created.
The following tags have been created so far
hdapsd-20090401-4_fc13:devel:ttorcz:1252079380
hdapsd-20090401-4_fc12:F-12:ttorcz:1252079571
cvs tag: Pre-tag check failed
cvs [tag aborted]: correct the above errors first!
make: *** [tag] Error 1


What to do?

BTW, koji build is here: http://koji.fedoraproject.org/koji/buildinfo?buildID=130621

Currently F-12 koji build will go to rawhide tree directly
so "make update" is not needed.

(By the way if you want to build this for F-11 please see
 https://fedoraproject.org/wiki/CVS_admin_requests
 and write "Package Change Request" here)

Closing as F-12/13 build is done.

I've got my laptop upgrade to rawhide, so I will pass F11. I wouldn't have chance to maintain it properly.
Thank you very much for review and sponsorship!