Bug 505982
| Summary: | Review Request: zikula-module-MultiHook - MultiHook is a simple replacement for the old AutoLinks module for Zikula | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | eric |
| Component: | Package Review | Assignee: | Ian Weller <ian> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | david, eric, fedora-package-review, ian, notting |
| Target Milestone: | --- | Flags: | ian:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 5.0-4.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-27 21:26:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 505939 | ||
|
Description
eric
2009-06-15 03:16:03 UTC
(prelim review, i'm not a sponsor, needs a formal review, etc) %changelog: Since you did this one yourself you most definitely need to change it to your name and email. %doc: There are a lot more docs available in the pndocs/ dir than what you have listed. rpmlint output: zikula-module-MultiHook.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1) zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/license.txt zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/credits.txt zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/changelog.txt Spec URL: http://sparks.fedorapeople.org/Packages/zikula-module-MultiHook/zikula-module-MultiHook.spec SRPM URL: http://sparks.fedorapeople.org/Packages/zikula-module-MultiHook/zikula-module-MultiHook-5.0-2.fc11.src.rpm Fixed. No errors/warnings on rpmlint output. Thanks for the reminder! Hey, now that you are sponsored, I guess I'll take this. :) [ianweller@deathray review]$ rpmlint /home/ianweller/rpmbuild/RPMS/noarch/zikula-module-MultiHook-5.0-2.fc11.noarch.rpm zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/license.txt zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/install.txt zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/needles_howto.txt zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/credits.txt zikula-module-MultiHook.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-MultiHook-5.0/changelog.txt 1 packages and 0 specfiles checked; 0 errors, 5 warnings. please fix :) Spec URL: http://sparks.fedorapeople.org/Packages/zikula-module-MultiHook/zikula-module-MultiHook.spec SRPM URL: http://sparks.fedorapeople.org/Packages/zikula-module-MultiHook/zikula-module-MultiHook-5.0-3.fc11.src.rpm Should have fixed those warnings. == FULL REVIEW == [ OK ] specfiles match: 72e5cecad7897770a6b0b4859cdf2308 zikula-module-MultiHook.spec 72e5cecad7897770a6b0b4859cdf2308 zikula-module-MultiHook.spec.1 [ OK ] source files match upstream: 7bcef21d80df346133ce6742b9b7bbb6 MultiHook_5.0.zip 7bcef21d80df346133ce6742b9b7bbb6 MultiHook_5.0.zip.1 [ OK ] package meets naming and versioning guidelines. [ SURE ] spec is properly named, cleanly written, and uses macros consistently. I'd add line breaks in between each %changelog entry for legibility, but that's a matter of taste. [ OK ] dist tag is present. [ OK ] build root is correct. [FAILED] license field matches the actual license. It's actually GPLv2+, check the source files (says "any later version"). [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ N/A ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ N/A ] debuginfo package looks complete. [FAILED] rpmlint is silent. zikula-module-MultiHook.src: W: strange-permission MultiHook_5.0.zip 0770 Very minor issue, a matter of chmodding your source file in rpmbuild/SOURCES to 644 or 664. [ OK ] final provides and requires are sane [ N/A ] %check is present and all tests pass: [ N/A ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ N/A ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ N/A ] desktop files valid and installed properly. Please fix. Spec URL: http://sparks.fedorapeople.org/Packages/zikula-module-MultiHook/zikula-module-MultiHook.spec SRPM URL: http://sparks.fedorapeople.org/Packages/zikula-module-MultiHook/zikula-module-MultiHook-5.0-4.fc11.src.rpm Alrighty, those are fixed. ---------------------------------------------------------------------- This package (zikula-module-MultiHook) is APPROVED by me (ianweller) ---------------------------------------------------------------------- New Package CVS Request ======================= Package Name: zikula-module-MultiHook Short Description: MultiHook is a simple replacement for the old AutoLinks module for Zikula Owners: sparks ke4qqq Branches: F-10 F-11 EL-5 InitialCC: cvs done. zikula-module-MultiHook-5.0-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/zikula-module-MultiHook-5.0-4.fc10 zikula-module-MultiHook-5.0-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/zikula-module-MultiHook-5.0-4.fc11 zikula-module-MultiHook-5.0-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/zikula-module-MultiHook-5.0-4.el5 zikula-module-MultiHook-5.0-4.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zikula-module-MultiHook'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0078 zikula-module-MultiHook-5.0-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zikula-module-MultiHook'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7726 zikula-module-MultiHook-5.0-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zikula-module-MultiHook'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7728 zikula-module-MultiHook-5.0-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. zikula-module-MultiHook-5.0-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. zikula-module-MultiHook-5.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |