Bug 506007
| Summary: | Review Request: perl-Sub-WrapPackages - Add wrappers around all the subroutines in packages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.2-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-30 21:43:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Emmanuel Seyman
2009-06-15 08:47:11 UTC
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1414511 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e93348e9d3d4cec8629f95509ab5cc949b7b0008 Sub-WrapPackages-1.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=10, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.10 cusr 0.05 csys = 0.17 CPU) + Package perl-Sub-WrapPackages-1.2-1.fc12.noarch => Provides: perl(Sub::WrapPackages) = 1.2 Requires: perl(Data::Dumper) perl(Hook::LexWrap) perl(strict) perl(vars) perl(warnings) + Not a GUI application APPROVED. Thanks for the review, Panag! Requesting cvs. New Package CVS Request ======================= Package Name: perl-Sub-WrapPackages Short Description: Add wrappers around all the subroutines in packages Owners: eseyman Branches: F-11 F-10 InitialCC: perl-sig CVS done. perl-Sub-WrapPackages-1.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Sub-WrapPackages-1.2-1.fc11 perl-Sub-WrapPackages-1.2-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Sub-WrapPackages'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6841 perl-Sub-WrapPackages-1.2-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |