Bug 506429

- Is there a reason to package a SVN version rather than the official 0.8.0 ? (not a problem, just to know)

- Better URL seems to be http://eclox.eu/

- According to source file (eclox.core/src/eclox/core/Plugin.java p.e.) License is GPLv2+

- AUTHORS, CHANGES, COPYING, MANUAL, README and TODO still present despite of eclipse-eclox-bin_excludes.patch.

- It will be usefull to add them  in %doc
(perhaps, even with the full version download in your script eclipse-eclox-download.sh)

- Build and load ok (not really tested yet)

(In reply to comment #1)
> - Is there a reason to package a SVN version rather than the official 0.8.0 ?
> (not a problem, just to know)

I was unable to find the sources of eclo, except compiled jars from upstream. Hence I pull the sources from svn.

> - Better URL seems to be http://eclox.eu/

fixed

> - According to source file (eclox.core/src/eclox/core/Plugin.java p.e.) License
> is GPLv2+

fixed

> - AUTHORS, CHANGES, COPYING, MANUAL, README and TODO still present despite of
> eclipse-eclox-bin_excludes.patch.

Actually, the patch was working, but there was also the build.properties of eclox.help which needed a similar patch

Updated  

Spec URL: http://chitlesh.fedorapeople.org/RPMS/eclipse-eclox.spec
SRPM URL:
http://chitlesh.fedorapeople.org/RPMS/eclipse-eclox-0.8.0-2.20090616svn.fc11.src.rpm

> I was unable to find the sources of eclo, except compiled jars from upstream.
> Hence I pull the sources from svn.
I've also search in SVN and don't find any usefull tag :(

Should ask upstream (for future release) to provide a source tarball or simply a SVN tag.



REVIEW : 

+ RPMLINT is ok
eclipse-eclox-0.8.0-2.20090616svn.fc8.noarch.rpm
eclipse-eclox.src: I: checking
eclipse-eclox.src: W: strange-permission eclipse-eclox-download.sh 0755
eclipse-eclox.noarch: I: checking
+ package name ok 
+ spec filename ok
+ license ok
+ license match ok
+ upstream COPYING provided (link to website)
+ specfile in english and legible
+ source from SVN
+ BR okown all directories that it creates
+ build ok F11.x86_64
+ no locale
+ no shared library (no -devel needed)
+ own all directories that it creates
+ defattr ok
+ clean ok
+ macros ok
+ only code
+ small doc (no split needed, not required to run)
+ no desktop needed
+ not own files or directories already owned by other packages
+ install start with clean
+ all file are UTF8
+ build in mock (fedora-rawhide-x86_64)
+ package install and run 

APPROVED

New Package CVS Request
=======================
Package Name: eclipse-eclox
Short Description: Eclipse-based doxygen plugin
Owners: chitlesh
Branches: F-10 F11 EL-5

Note that "F11" is not a branch name; I created an F-11 branch instead.

CVS done.

eclipse-eclox-0.8.0-2.20090616svn.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/eclipse-eclox-0.8.0-2.20090616svn.fc11

eclipse-eclox-0.8.0-2.20090616svn.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.