Bug 506644

It is not happening all of the time. A test I ran last not on an i386 arch ran to normal completion. I'll be retesting on the machine I saw the problem which is an x86_64 arch machine.

It's definitely intermittant. I retested on the machine I originally saw the problem and things ran normally to completion.

What's the host running?  I saw this once and then realized I was running and older gvfs2 stack on the box and that the desktop was mounting the snapshot (from which point, no, it couldn't be removed)

I am not sure what the context is.
It's a Fedora 11 machine with X86_64 and some i586 libs.
I have F11, updates, updates-testing, rpm fusion, updates, updates-testing and livna repos active.
I am seeing something else odd with boots that might be device mapper related.
I am going to try some more livecd-creator runs to see if it keeps happening or starts happening on the other machine.

Retesting on the x86_64 machine got a normal run. So maybe the system was in an odd state when I had the problem occur. I doubt there is much to be done unless I can get it to happen again.

I've been doing a fair bit of builds and haven't hit it on my x86_64 F11 box (since I haven't updated to rawhide since I'm not in the office for a few weeks and don't want to be without my build box)

If you see it again, feel free to reopen but this might just be transient device-mapper bogons :/

That's OK. I was going to do the same thing; I just hadn't gotten to it yet.
I haven't seen the failure since (including yesterday when a spin build worked fine), so I am thinking my system probably had gotten into a weird state. And there have been updates since then so even if something had been broken then, it might not be any more.

I just saw it with livecd-tools-024-1.fc11.i586:

Losetup add /dev/loop0 mapping to /var/tmp/imgcreate-O5x5lH/tmp-I2Cboh/ext3fs.img
Extending sparse file /var/tmp/imgcreate-O5x5lH/iso-2hBDyT/LiveOS/osmin to 67108864
Losetup add /dev/loop1 mapping to /var/tmp/imgcreate-O5x5lH/iso-2hBDyT/LiveOS/osmin
device-mapper: remove ioctl failed: Device or resource busy
Command failed
/usr/lib/python2.6/site-packages/imgcreate/errors.py:45: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
  return unicode(self.message)
Error creating Live CD : Could not remove snapshot device

and with kernel message
device-mapper: ioctl: unable to remove open device imgcreate-3660-14231

I think I have worked around this issue before by adding 1 s sleeps some places.

I think this issue is real even though it can't be reproduced reliably, so I will reopen it.

I have DeviceKit-disks-004-4.fc11.i586, so I assume that it isn't bug 488756

Where are you adding sleeps that seems to help?

I think that something like this has helped before, but right now it works for me, so i can not confirm that it makes a difference. But I'm sure I'll notice when it happens ...

--- /usr/lib/python2.6/site-packages/imgcreate/fs.py.org	2009-08-13 13:59:23.000000000 +0200
+++ /usr/lib/python2.6/site-packages/imgcreate/fs.py	2009-08-14 17:08:04.000000000 +0200
@@ -511,7 +511,13 @@
         if not self.__created:
             return
 
-        rc = subprocess.call(["/sbin/dmsetup", "remove", self.__name])
+        for i in range(10):
+            rc = subprocess.call(["/sbin/dmsetup", "remove", self.__name])
+            if rc == 0:
+                break
+            logging.debug('%s: Error removing snapshot device %s' % (i, self.__name))
+            import time ; time.sleep(0.1)
+            import os; os.system('xeyes')
         if not ignore_errors and rc != 0:
             raise SnapshotError("Could not remove snapshot device")

But perhaps a fuser -m would be interesting here too?

It seemed to me like ignore_errors was set in too many cases.

Got it!

...
Losetup add /dev/loop0 mapping to /var/tmp/imgcreate-xOyoxY/tmp-EHEKod/ext3fs.img
Extending sparse file /var/tmp/imgcreate-xOyoxY/iso-XAmGwe/LiveOS/osmin to 67108864
Losetup add /dev/loop1 mapping to /var/tmp/imgcreate-xOyoxY/iso-XAmGwe/LiveOS/osmin
device-mapper: remove ioctl failed: Device or resource busy
Command failed
0: Error removing snapshot device imgcreate-3546-63608
^Z
[1]+  Stopped

[root@localhost lars]# fuser -m /dev/mapper/imgcreate-3546-63608
[root@localhost lars]# killall xeyes
[root@localhost lars]# fg
Losetup remove /dev/loop1
Losetup remove /dev/loop0
Truncating sparse file /var/tmp/imgcreate-xOyoxY/iso-XAmGwe/LiveOS/osmin to 8192
Parallel mksquashfs: Using 2 processors
...

So: There is some kind of race, but the race ended before I ran fuser...

Added a sleep.  Kludgey, but if it helps, then I'll just be happy about it.