Bug 507061

Summary:	Review Request: perl-CGI-Application-Plugin-Stream - CGI::Application Plugin for streaming files
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	2.10-1.fc11	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-06-30 21:30:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2009-06-20 11:41:09 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-Stream/perl-CGI-Application-Plugin-Stream.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-Stream/perl-CGI-Application-Plugin-Stream-2.10-1.fc11.src.rpm
Description:
This plugin provides a way to stream a file back to the user, which is
useful if you are creating a PDF or Spreadsheet document dynamically to
deliver to the user.

Comment 1 Parag AN(पराग) 2009-06-22 05:45:09 UTC

Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1428530
- rpmlint is silent for SRPM and for RPM.
perl-CGI-Application-Plugin-Stream.noarch: W: incoherent-version-in-changelog 2.06-1 ['2.10-1.fc12', '2.10-1']
==> fix this
+ source files match upstream url
78cca2cefe005f59c440a362c4cbeeaa12cf115b  CGI-Application-Plugin-Stream-2.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=16,  0 wallclock secs ( 0.01 usr  0.02 sys +  0.30 cusr  0.04 csys =  0.37 CPU)
+ Package perl-CGI-Application-Plugin-Stream-2.10-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::Stream) = 2.10
Requires: perl >= 0:5.006 perl(CGI::Application) >= 3.21 perl(Exporter) perl(File::Basename) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

Suggestions:
1) Fix changelog entry before cvs import.
2) You need to 
Requires: perl(File::MMagic), not picked up by yum.
APPROVED.

Comment 2 Emmanuel Seyman 2009-06-23 07:12:39 UTC

(In reply to comment #1)
>
> Suggestions:
> 1) Fix changelog entry before cvs import.

Done.

> 2) You need to 
> Requires: perl(File::MMagic), not picked up by yum.

Done.

> APPROVED.  

Thanks, Parag!
Requesting cvs.

New Package CVS Request
=======================
Package Name: perl-CGI-Application-Plugin-Session
Short Description: Add CGI::Session support to CGI::Application
Owners: eseyman
Branches: F-11 F-10
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2009-06-23 17:44:50 UTC

You seem to have made a CVS request for the wrong package.

Comment 4 Emmanuel Seyman 2009-06-23 22:56:28 UTC

(In reply to comment #3)
>
> You seem to have made a CVS request for the wrong package.  

That will teach me to copy/paste CVS requests.

New Package CVS Request
=======================
Package Name: perl-CGI-Application-Plugin-Stream
Short Description: CGI::Application Plugin for streaming files
Owners: eseyman
Branches: F-11 F-10
InitialCC: perl-sig

Comment 5 Kevin Fenzi 2009-06-24 18:16:32 UTC

cvs done.

Comment 6 Fedora Update System 2009-06-24 20:55:08 UTC

perl-CGI-Application-Plugin-Stream-2.10-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-Stream-2.10-1.fc11

Comment 7 Fedora Update System 2009-06-27 03:00:53 UTC

perl-CGI-Application-Plugin-Stream-2.10-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-Stream'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7045

Comment 8 Fedora Update System 2009-06-30 21:30:26 UTC

perl-CGI-Application-Plugin-Stream-2.10-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.